Skip to content

Commit fe6e074

Browse files
authored
Fix usage of console.error to prevent transform (#24188)
We were suppressing the `react-internals/warning-args` lint rule for the call to `console.error` in `defaultOnRecoverableError`. As far as I could tell, the lint rule exists because on dev builds, we replace all calls to `console.error` with [this error function](https://github.com/facebook/react/blob/main/packages/shared/consoleWithStackDev.js#L31-L37) which expects a format string + args and nothing else. We were trying to pass in an `Error` object directly. After this commit's change, we will still be passing an `Error` but the transform won't occur.
1 parent ba0aee5 commit fe6e074

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

packages/react-dom/src/client/ReactDOMRoot.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,8 @@ const defaultOnRecoverableError =
8181
reportError
8282
: (error: mixed) => {
8383
// In older browsers and test environments, fallback to console.error.
84-
// eslint-disable-next-line react-internal/no-production-logging, react-internal/warning-args
85-
console.error(error);
84+
// eslint-disable-next-line react-internal/no-production-logging
85+
console['error'](error);
8686
};
8787

8888
function ReactDOMRoot(internalRoot: FiberRoot) {

0 commit comments

Comments
 (0)