Skip to content

Commit 6e2f38f

Browse files
authored
[DevTools] Remove string.replaceAll Call in @reactVersion Pragma Functions (#24584)
`string.replaceAll` doesn't exist in our CircleCI Docker environment. We also don't need it in this case because `semver.satisfies` allows for whitespace when specifying a range. This PR removes the unnecessary call.
1 parent d89657b commit 6e2f38f

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

scripts/jest/devtools/setupEnv.js

+2-4
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,8 @@ global.process.env.LIGHT_MODE_DIMMED_ERROR_COLOR = LIGHT_MODE_DIMMED_ERROR_COLOR
2929
global.process.env.LIGHT_MODE_DIMMED_LOG_COLOR = LIGHT_MODE_DIMMED_LOG_COLOR;
3030

3131
global._test_react_version = (range, testName, callback) => {
32-
const trimmedRange = range.replaceAll(' ', '');
3332
const reactVersion = process.env.REACT_VERSION || ReactVersion.default;
34-
const shouldPass = semver.satisfies(reactVersion, trimmedRange);
33+
const shouldPass = semver.satisfies(reactVersion, range);
3534

3635
if (shouldPass) {
3736
test(testName, callback);
@@ -41,9 +40,8 @@ global._test_react_version = (range, testName, callback) => {
4140
};
4241

4342
global._test_react_version_focus = (range, testName, callback) => {
44-
const trimmedRange = range.replaceAll(' ', '');
4543
const reactVersion = process.env.REACT_VERSION || ReactVersion.default;
46-
const shouldPass = semver.satisfies(reactVersion, trimmedRange);
44+
const shouldPass = semver.satisfies(reactVersion, range);
4745

4846
if (shouldPass) {
4947
// eslint-disable-next-line jest/no-focused-tests

0 commit comments

Comments
 (0)