Skip to content

Commit fd5de50

Browse files
RSNarafacebook-github-bot
RSNara
authored and
facebook-github-bot
committed
Fix Cocoapods builds
Summary: ## Problem For some reason, D20831545 broke the `use_frameworks!` build of RNTester. ## Building RNTester ``` pushd ~/fbsource/xplat/js/react-native-github/RNTester && USE_FRAMEWORKS=1 pod install && open RNTesterPods.xcworkspace && popd; ``` ## Error I built RNTester locally, and the error was this: ``` Undefined symbols for architecture x86_64: "facebook::jsi::HostObject::set(facebook::jsi::Runtime&, facebook::jsi::PropNameID const&, facebook::jsi::Value const&)", referenced from: vtable for facebook::react::ObjCTurboModule in RCTImageEditingManager.o vtable for facebook::react::ObjCTurboModule in RCTImageLoader.o vtable for facebook::react::ObjCTurboModule in RCTImageStoreManager.o "facebook::jsi::HostObject::getPropertyNames(facebook::jsi::Runtime&)", referenced from: vtable for facebook::react::ObjCTurboModule in RCTImageEditingManager.o vtable for facebook::react::ObjCTurboModule in RCTImageLoader.o vtable for facebook::react::ObjCTurboModule in RCTImageStoreManager.o ld: symbol(s) not found for architecture x86_64 ``` ## Fix It looked like libraries that depend on "ReactCommon/turbomodule/core" weren't linking to JSI correctly. So, I modified all such Podspecs to also depend on "React-jsi": ``` arc rfr ' s.dependency "ReactCommon/turbomodule/core", version' ' s.dependency "ReactCommon/turbomodule/core", version\n s.dependency "React-jsi", version' ``` This seemed to do the trick. In buck, we'd fix this problem using exported_dependencies. I skimmed through cocoapods, and couldn't find such a configuration option there. So, I guess this will have to do? Changelog: [iOS][Fixed] - Fix Cocoapods builds of RNTester Reviewed By: fkgozali, hramos Differential Revision: D20905465 fbshipit-source-id: 60218c8274ec165752a428f2a7a9a546607c8fec
1 parent 3904228 commit fd5de50

File tree

11 files changed

+42
-10
lines changed

11 files changed

+42
-10
lines changed

‎Libraries/Blob/React-RCTBlob.podspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ Pod::Spec.new do |s|
4141
s.dependency "Folly", folly_version
4242
s.dependency "FBReactNativeSpec", version
4343
s.dependency "ReactCommon/turbomodule/core", version
44+
s.dependency "React-jsi", version
4445
s.dependency "React-Core/RCTBlobHeaders", version
4546
s.dependency "React-Core/RCTWebSocket", version
4647
s.dependency "React-RCTNetwork", version

‎Libraries/Image/React-RCTImage.podspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ Pod::Spec.new do |s|
4343
s.dependency "FBReactNativeSpec", version
4444
s.dependency "RCTTypeSafety", version
4545
s.dependency "ReactCommon/turbomodule/core", version
46+
s.dependency "React-jsi", version
4647
s.dependency "React-Core/RCTImageHeaders", version
4748
s.dependency "React-RCTNetwork", version
4849
end

‎Libraries/LinkingIOS/React-RCTLinking.podspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,4 +42,5 @@ Pod::Spec.new do |s|
4242
s.dependency "FBReactNativeSpec", version
4343
s.dependency "React-Core/RCTLinkingHeaders", version
4444
s.dependency "ReactCommon/turbomodule/core", version
45+
s.dependency "React-jsi", version
4546
end

‎Libraries/NativeAnimation/React-RCTAnimation.podspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ Pod::Spec.new do |s|
4141
s.dependency "Folly", folly_version
4242
s.dependency "RCTTypeSafety", version
4343
s.dependency "ReactCommon/turbomodule/core", version
44+
s.dependency "React-jsi", version
4445
s.dependency "FBReactNativeSpec", version
4546
s.dependency "React-Core/RCTAnimationHeaders", version
4647
end

‎Libraries/Network/React-RCTNetwork.podspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,5 +43,6 @@ Pod::Spec.new do |s|
4343
s.dependency "FBReactNativeSpec", version
4444
s.dependency "RCTTypeSafety", version
4545
s.dependency "ReactCommon/turbomodule/core", version
46+
s.dependency "React-jsi", version
4647
s.dependency "React-Core/RCTNetworkHeaders", version
4748
end

‎Libraries/PushNotificationIOS/React-RCTPushNotification.podspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,4 +44,5 @@ Pod::Spec.new do |s|
4444
s.dependency "RCTTypeSafety", version
4545
s.dependency "React-Core/RCTPushNotificationHeaders", version
4646
s.dependency "ReactCommon/turbomodule/core", version
47+
s.dependency "React-jsi", version
4748
end

‎Libraries/Settings/React-RCTSettings.podspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,5 +43,6 @@ Pod::Spec.new do |s|
4343
s.dependency "FBReactNativeSpec", version
4444
s.dependency "RCTTypeSafety", version
4545
s.dependency "ReactCommon/turbomodule/core", version
46+
s.dependency "React-jsi", version
4647
s.dependency "React-Core/RCTSettingsHeaders", version
4748
end

‎Libraries/Vibration/React-RCTVibration.podspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,5 +43,6 @@ Pod::Spec.new do |s|
4343
s.dependency "Folly", folly_version
4444
s.dependency "FBReactNativeSpec", version
4545
s.dependency "ReactCommon/turbomodule/core", version
46+
s.dependency "React-jsi", version
4647
s.dependency "React-Core/RCTVibrationHeaders", version
4748
end

‎RNTester/Podfile.lock

Lines changed: 32 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,7 @@ PODS:
226226
- Folly (= 2020.01.13.00)
227227
- RCTTypeSafety (= 1000.0.0)
228228
- React-Core/CoreModulesHeaders (= 1000.0.0)
229+
- React-jsi (= 1000.0.0)
229230
- React-RCTImage (= 1000.0.0)
230231
- ReactCommon/turbomodule/core (= 1000.0.0)
231232
- React-cxxreact (1000.0.0):
@@ -260,6 +261,7 @@ PODS:
260261
- Folly (= 2020.01.13.00)
261262
- RCTTypeSafety (= 1000.0.0)
262263
- React-Core/RCTAnimationHeaders (= 1000.0.0)
264+
- React-jsi (= 1000.0.0)
263265
- ReactCommon/turbomodule/core (= 1000.0.0)
264266
- React-RCTBlob (1000.0.0):
265267
- FBReactNativeSpec (= 1000.0.0)
@@ -274,28 +276,33 @@ PODS:
274276
- Folly (= 2020.01.13.00)
275277
- RCTTypeSafety (= 1000.0.0)
276278
- React-Core/RCTImageHeaders (= 1000.0.0)
279+
- React-jsi (= 1000.0.0)
277280
- React-RCTNetwork (= 1000.0.0)
278281
- ReactCommon/turbomodule/core (= 1000.0.0)
279282
- React-RCTLinking (1000.0.0):
280283
- FBReactNativeSpec (= 1000.0.0)
281284
- React-Core/RCTLinkingHeaders (= 1000.0.0)
285+
- React-jsi (= 1000.0.0)
282286
- ReactCommon/turbomodule/core (= 1000.0.0)
283287
- React-RCTNetwork (1000.0.0):
284288
- FBReactNativeSpec (= 1000.0.0)
285289
- Folly (= 2020.01.13.00)
286290
- RCTTypeSafety (= 1000.0.0)
287291
- React-Core/RCTNetworkHeaders (= 1000.0.0)
292+
- React-jsi (= 1000.0.0)
288293
- ReactCommon/turbomodule/core (= 1000.0.0)
289294
- React-RCTPushNotification (1000.0.0):
290295
- FBReactNativeSpec (= 1000.0.0)
291296
- RCTTypeSafety (= 1000.0.0)
292297
- React-Core/RCTPushNotificationHeaders (= 1000.0.0)
298+
- React-jsi (= 1000.0.0)
293299
- ReactCommon/turbomodule/core (= 1000.0.0)
294300
- React-RCTSettings (1000.0.0):
295301
- FBReactNativeSpec (= 1000.0.0)
296302
- Folly (= 2020.01.13.00)
297303
- RCTTypeSafety (= 1000.0.0)
298304
- React-Core/RCTSettingsHeaders (= 1000.0.0)
305+
- React-jsi (= 1000.0.0)
299306
- ReactCommon/turbomodule/core (= 1000.0.0)
300307
- React-RCTTest (1000.0.0):
301308
- Folly (= 2020.01.13.00)
@@ -309,6 +316,7 @@ PODS:
309316
- FBReactNativeSpec (= 1000.0.0)
310317
- Folly (= 2020.01.13.00)
311318
- React-Core/RCTVibrationHeaders (= 1000.0.0)
319+
- React-jsi (= 1000.0.0)
312320
- ReactCommon/turbomodule/core (= 1000.0.0)
313321
- ReactCommon/turbomodule/core (1000.0.0):
314322
- DoubleConversion
@@ -335,8 +343,22 @@ DEPENDENCIES:
335343
- DoubleConversion (from `../third-party-podspecs/DoubleConversion.podspec`)
336344
- FBLazyVector (from `../Libraries/FBLazyVector`)
337345
- FBReactNativeSpec (from `../Libraries/FBReactNativeSpec`)
346+
- Flipper (~> 0.33.1)
347+
- Flipper-DoubleConversion (= 1.1.7)
348+
- Flipper-Folly (~> 2.1)
349+
- Flipper-Glog (= 0.3.6)
350+
- Flipper-PeerTalk (~> 0.0.4)
351+
- Flipper-RSocket (~> 1.0)
338352
- FlipperKit (~> 0.33.1)
353+
- FlipperKit/Core (~> 0.33.1)
354+
- FlipperKit/CppBridge (~> 0.33.1)
355+
- FlipperKit/FBCxxFollyDynamicConvert (~> 0.33.1)
356+
- FlipperKit/FBDefines (~> 0.33.1)
357+
- FlipperKit/FKPortForwarding (~> 0.33.1)
358+
- FlipperKit/FlipperKitHighlightOverlay (~> 0.33.1)
339359
- FlipperKit/FlipperKitLayoutPlugin (~> 0.33.1)
360+
- FlipperKit/FlipperKitLayoutTextSearchable (~> 0.33.1)
361+
- FlipperKit/FlipperKitNetworkPlugin (~> 0.33.1)
340362
- FlipperKit/FlipperKitReactPlugin (~> 0.33.1)
341363
- FlipperKit/FlipperKitUserDefaultsPlugin (~> 0.33.1)
342364
- FlipperKit/SKIOSNetworkPlugin (~> 0.33.1)
@@ -468,26 +490,26 @@ SPEC CHECKSUMS:
468490
React-ART: df0460bdff42ef039e28ee3ffd41f50b75644788
469491
React-callinvoker: 0dada022d38b73e6e15b33e2a96476153f79bbf6
470492
React-Core: 08c69f013e6fd654ea8f9fd84bbd66780a54d886
471-
React-CoreModules: 0b59c833afcc9735e5a0220997fb18876dc9e52c
493+
React-CoreModules: d13d148c851af5780f864be74bc2165140923dc7
472494
React-cxxreact: 091da030e879ed93d970e95dd74fcbacb2a1d661
473495
React-jsi: fe94132da767bfc4801968c2a12abae43e9a833e
474496
React-jsiexecutor: 55eff40b2e0696e7a979016e321793ec8b28a2ac
475497
React-jsinspector: 7fbf9b42b58b02943a0d89b0ba9fff0070f2de98
476498
React-RCTActionSheet: 51c43beeb74ef41189e87fe9823e53ebf6210359
477-
React-RCTAnimation: 528462d8fe78787f2e058062cd9a4b44735ea579
478-
React-RCTBlob: e29e0277cbcd91f07719d8411a3fa5db6600b4cf
479-
React-RCTImage: a24587309c984427ec74d3c7be13b00ca0caabeb
480-
React-RCTLinking: 696a3911a5d380ba87e29fde099a811e51e69e2f
481-
React-RCTNetwork: cc2ccdcbf13dbea0710ef887e0b9ceae7f5aef28
482-
React-RCTPushNotification: 13befc7c6efba31625fd9a945dfa71a31b724b4a
483-
React-RCTSettings: a2b148ef74dcb98369e5bb0def506d2d29125ab3
499+
React-RCTAnimation: 9d09196c641c1ebfef3a4e9ae670bcda5fadb420
500+
React-RCTBlob: 715489626cf44d28ee51e5277a4d559167351696
501+
React-RCTImage: 19151d2d071b05c3832a0b212473cafa4ea8948f
502+
React-RCTLinking: 7c94c0f2fcc658cb4043dacb4f6621dca2f8f8b5
503+
React-RCTNetwork: 7596e84acacd5d0674e9743b55c5bf61a626af69
504+
React-RCTPushNotification: 88c9f47ff0d4391d5136d70745f15713cdc5f6bb
505+
React-RCTSettings: a29c61f85f535ba2eff54d80bef2ea3cdb6e5fba
484506
React-RCTTest: cfe25fcf70b04a747dba4326105db398250caa9a
485507
React-RCTText: 6c01963d3e562109f5548262b09b1b2bc260dd60
486-
React-RCTVibration: d218336fa28ade97e99b4ddb935f1de5c670e361
508+
React-RCTVibration: d42d73dafd9f63cf758656ee743aa80c566798ff
487509
ReactCommon: 39e00b754f5e1628804fab28f44146d06280f700
488510
Yoga: f7fa200d8c49f97b54c9421079e781fb900b5cae
489511
YogaKit: f782866e155069a2cca2517aafea43200b01fd5a
490512

491513
PODFILE CHECKSUM: 5f0be4be03d6934478b9dd621bfbab4383b8c85d
492514

493-
COCOAPODS: 1.8.4
515+
COCOAPODS: 1.9.1

‎React/CoreModules/React-CoreModules.podspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,4 +43,5 @@ Pod::Spec.new do |s|
4343
s.dependency "React-Core/CoreModulesHeaders", version
4444
s.dependency "React-RCTImage", version
4545
s.dependency "ReactCommon/turbomodule/core", version
46+
s.dependency "React-jsi", version
4647
end

‎ReactCommon/React-Fabric.podspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ Pod::Spec.new do |s|
4242
s.dependency "RCTRequired", version
4343
s.dependency "RCTTypeSafety", version
4444
s.dependency "ReactCommon/turbomodule/core", version
45+
s.dependency "React-jsi", version
4546

4647
s.subspec "attributedstring" do |ss|
4748
ss.dependency folly_dep_name, folly_version

0 commit comments

Comments
 (0)