Skip to content

Commit 93e58b2

Browse files
jbrown215facebook-github-bot
authored andcommitted
Suppressions for 0.111
Summary: still some generated files in www that need to land before we can release 0.111 here. drop-conflicts Changelog: [Internal] (Note: this ignores all push blocking failures!) Reviewed By: dsainati1 Differential Revision: D18278838 fbshipit-source-id: b20c3fefb3aab7c5fb614b33d846c7548184f49a
1 parent 5ee365f commit 93e58b2

File tree

14 files changed

+63
-2
lines changed

14 files changed

+63
-2
lines changed

Libraries/Animated/src/AnimatedImplementation.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,9 @@ const spring = function(
169169

170170
_startNativeLoop: function(iterations?: number): void {
171171
const singleConfig = {...config, iterations};
172+
/* $FlowFixMe(>=0.111.0 site=react_native_fb) This comment suppresses
173+
* an error found when Flow v0.111 was deployed. To see the error,
174+
* delete this comment and run Flow. */
172175
start(value, singleConfig);
173176
},
174177

@@ -223,6 +226,9 @@ const timing = function(
223226

224227
_startNativeLoop: function(iterations?: number): void {
225228
const singleConfig = {...config, iterations};
229+
/* $FlowFixMe(>=0.111.0 site=react_native_fb) This comment suppresses
230+
* an error found when Flow v0.111 was deployed. To see the error,
231+
* delete this comment and run Flow. */
226232
start(value, singleConfig);
227233
},
228234

@@ -265,6 +271,9 @@ const decay = function(
265271

266272
_startNativeLoop: function(iterations?: number): void {
267273
const singleConfig = {...config, iterations};
274+
/* $FlowFixMe(>=0.111.0 site=react_native_fb) This comment suppresses
275+
* an error found when Flow v0.111 was deployed. To see the error,
276+
* delete this comment and run Flow. */
268277
start(value, singleConfig);
269278
},
270279

Libraries/Components/Touchable/Touchable.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -950,6 +950,9 @@ const Touchable = {
950950
pointerEvents="none"
951951
style={[
952952
styles.debug,
953+
/* $FlowFixMe(>=0.111.0 site=react_native_fb) This comment suppresses
954+
* an error found when Flow v0.111 was deployed. To see the error,
955+
* delete this comment and run Flow. */
953956
{
954957
borderColor: hexColor.slice(0, -2) + '55', // More opaque
955958
backgroundColor: hexColor.slice(0, -2) + '0F', // Less opaque

Libraries/Components/Touchable/TouchableNativeFeedback.android.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -346,6 +346,9 @@ const TouchableNativeFeedbackImpl = createReactClass({
346346
: 'nativeBackgroundAndroid';
347347
const childProps = {
348348
...child.props,
349+
/* $FlowFixMe(>=0.111.0 site=react_native_android_fb) This comment
350+
* suppresses an error found when Flow v0.111 was deployed. To see the
351+
* error, delete this comment and run Flow. */
349352
[drawableProp]: this.props.background,
350353
accessible: this.props.accessible !== false,
351354
accessibilityLabel: this.props.accessibilityLabel,

Libraries/Core/setUpDeveloperTools.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ if (__DEV__) {
6363
'debug',
6464
].forEach(level => {
6565
const originalFunction = console[level];
66-
// $FlowFixMe Overwrite console methods
6766
console[level] = function(...args) {
6867
HMRClient.log(level, args);
6968
originalFunction.apply(console, args);

Libraries/Core/setUpReactDevTools.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
'use strict';
1212

1313
if (__DEV__) {
14-
// $FlowFixMe Module is untyped
1514
const reactDevTools = require('react-devtools-core');
1615
const connectToDevTools = () => {
1716
// not when debugging in chrome

Libraries/Lists/FlatList.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -559,6 +559,9 @@ class FlatList<ItemT> extends React.PureComponent<Props<ItemT>, void> {
559559
};
560560

561561
return {
562+
/* $FlowFixMe(>=0.111.0 site=react_native_fb) This comment suppresses an
563+
* error found when Flow v0.111 was deployed. To see the error, delete
564+
* this comment and run Flow. */
562565
[virtualizedListRenderKey]: (info: RenderItemProps<ItemT>) => {
563566
if (numColumns > 1) {
564567
const {item, index} = info;

Libraries/Lists/VirtualizedList.js

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -946,6 +946,9 @@ class VirtualizedList extends React.PureComponent<Props, State> {
946946
initBlock.offset -
947947
(this.props.initialScrollIndex ? 0 : initBlock.length);
948948
cells.push(
949+
/* $FlowFixMe(>=0.111.0 site=react_native_fb) This comment
950+
* suppresses an error found when Flow v0.111 was deployed. To
951+
* see the error, delete this comment and run Flow. */
949952
<View key="$sticky_lead" style={{[spacerKey]: leadSpace}} />,
950953
);
951954
this._pushCells(
@@ -960,6 +963,9 @@ class VirtualizedList extends React.PureComponent<Props, State> {
960963
this._getFrameMetricsApprox(first).offset -
961964
(stickyBlock.offset + stickyBlock.length);
962965
cells.push(
966+
/* $FlowFixMe(>=0.111.0 site=react_native_fb) This comment
967+
* suppresses an error found when Flow v0.111 was deployed. To
968+
* see the error, delete this comment and run Flow. */
963969
<View key="$sticky_trail" style={{[spacerKey]: trailSpace}} />,
964970
);
965971
insertedStickySpacer = true;
@@ -973,6 +979,9 @@ class VirtualizedList extends React.PureComponent<Props, State> {
973979
this._getFrameMetricsApprox(first).offset -
974980
(initBlock.offset + initBlock.length);
975981
cells.push(
982+
/* $FlowFixMe(>=0.111.0 site=react_native_fb) This comment
983+
* suppresses an error found when Flow v0.111 was deployed. To see
984+
* the error, delete this comment and run Flow. */
976985
<View key="$lead_spacer" style={{[spacerKey]: firstSpace}} />,
977986
);
978987
}
@@ -1007,6 +1016,9 @@ class VirtualizedList extends React.PureComponent<Props, State> {
10071016
endFrame.length -
10081017
(lastFrame.offset + lastFrame.length);
10091018
cells.push(
1019+
/* $FlowFixMe(>=0.111.0 site=react_native_fb) This comment suppresses
1020+
* an error found when Flow v0.111 was deployed. To see the error,
1021+
* delete this comment and run Flow. */
10101022
<View key="$tail_spacer" style={{[spacerKey]: tailSpacerLength}} />,
10111023
);
10121024
}
@@ -1211,6 +1223,9 @@ class VirtualizedList extends React.PureComponent<Props, State> {
12111223
invariant(
12121224
typeof props.refreshing === 'boolean',
12131225
'`refreshing` prop must be set as a boolean in order to use `onRefresh`, but got `' +
1226+
/* $FlowFixMe(>=0.111.0 site=react_native_fb) This comment suppresses
1227+
* an error found when Flow v0.111 was deployed. To see the error,
1228+
* delete this comment and run Flow. */
12141229
JSON.stringify(props.refreshing) +
12151230
'`',
12161231
);

Libraries/Modal/Modal.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -271,6 +271,9 @@ const styles = StyleSheet.create({
271271
position: 'absolute',
272272
},
273273
container: {
274+
/* $FlowFixMe(>=0.111.0 site=react_native_fb) This comment suppresses an
275+
* error found when Flow v0.111 was deployed. To see the error, delete this
276+
* comment and run Flow. */
274277
[side]: 0,
275278
top: 0,
276279
flex: 1,

Libraries/PermissionsAndroid/PermissionsAndroid.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,9 @@ class PermissionsAndroid {
216216
...rationale,
217217
};
218218
NativeDialogManagerAndroid.showAlert(
219+
/* $FlowFixMe(>=0.111.0 site=react_native_fb) This comment
220+
* suppresses an error found when Flow v0.111 was deployed. To see
221+
* the error, delete this comment and run Flow. */
219222
options,
220223
() => reject(new Error('Error showing rationale')),
221224
() =>

Libraries/ReactNative/PaperUIManager.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,9 @@ function getConstants(): Object {
3333
}
3434

3535
const UIManagerJS = {
36+
/* $FlowFixMe(>=0.111.0 site=react_native_fb) This comment suppresses an
37+
* error found when Flow v0.111 was deployed. To see the error, delete this
38+
* comment and run Flow. */
3639
...NativeUIManager,
3740
getConstants(): Object {
3841
return getConstants();

Libraries/Utilities/registerGeneratedViewConfig.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,14 +48,23 @@ function registerGeneratedViewConfig(
4848
Commands: {},
4949
bubblingEventTypes: {
5050
...ReactNativeViewViewConfig.bubblingEventTypes,
51+
/* $FlowFixMe(>=0.111.0 site=react_native_fb) This comment suppresses an
52+
* error found when Flow v0.111 was deployed. To see the error, delete
53+
* this comment and run Flow. */
5154
...(viewConfig.bubblingEventTypes || {}),
5255
},
5356
directEventTypes: {
5457
...ReactNativeViewViewConfig.directEventTypes,
58+
/* $FlowFixMe(>=0.111.0 site=react_native_fb) This comment suppresses an
59+
* error found when Flow v0.111 was deployed. To see the error, delete
60+
* this comment and run Flow. */
5561
...(viewConfig.directEventTypes || {}),
5662
},
5763
validAttributes: {
5864
...ReactNativeViewViewConfig.validAttributes,
65+
/* $FlowFixMe(>=0.111.0 site=react_native_fb) This comment suppresses an
66+
* error found when Flow v0.111 was deployed. To see the error, delete
67+
* this comment and run Flow. */
5968
...(viewConfig.validAttributes || {}),
6069
},
6170
};

RNTester/js/examples/FlatList/FlatListExample.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,9 @@ class FlatListExample extends React.PureComponent<Props, State> {
210210

211211
return {
212212
renderItem: undefined,
213+
/* $FlowFixMe(>=0.111.0 site=react_native_fb) This comment suppresses an
214+
* error found when Flow v0.111 was deployed. To see the error, delete
215+
* this comment and run Flow. */
213216
[flatListPropKey]: ({item, separators}) => {
214217
return (
215218
<ItemComponent

RNTester/js/examples/TurboModule/SampleTurboModuleExample.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,13 @@ class SampleTurboModuleExample extends React.Component<{||}, State> {
6464
_setResult(name, result) {
6565
this.setState(({testResults}) => ({
6666
testResults: {
67+
/* $FlowFixMe(>=0.111.0 site=react_native_fb) This comment suppresses
68+
* an error found when Flow v0.111 was deployed. To see the error,
69+
* delete this comment and run Flow. */
6770
...testResults,
71+
/* $FlowFixMe(>=0.111.0 site=react_native_fb) This comment suppresses
72+
* an error found when Flow v0.111 was deployed. To see the error,
73+
* delete this comment and run Flow. */
6874
[name]: {value: result, type: typeof result},
6975
},
7076
}));

packages/react-native-codegen/src/cli/combine/combine-js-to-schema.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,9 @@ function combineSchemas(files: Array<string>): SchemaType {
2626
const schema = FlowParser.parseFile(filename);
2727

2828
if (schema && schema.modules) {
29+
/* $FlowFixMe(>=0.111.0 site=react_native_fb) This comment suppresses
30+
* an error found when Flow v0.111 was deployed. To see the error,
31+
* delete this comment and run Flow. */
2932
merged.modules = {...merged.modules, ...schema.modules};
3033
}
3134
}

0 commit comments

Comments
 (0)