Skip to content

Commit 8e48dc0

Browse files
mdvaccafacebook-github-bot
authored andcommitted
Rename analyticsTag -> internal_analyticsTag in ImageView component
Summary: This diff renames the analyticsTag prop for the intenral_analyticsTag in ImageView component changelog: [internal] Creation of internal_analyticTag prop in ImageView, for now this prop is meant to be used internally. Reviewed By: TheSavior Differential Revision: D20904497 fbshipit-source-id: 2a28f746772ee0f9d657ec71549020c1f3e9d674
1 parent 22e318f commit 8e48dc0

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

Libraries/Image/Image.android.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ const ImageProps = {
9999
/**
100100
* Analytics Tag used by this Image
101101
*/
102-
analyticTag: PropTypes.string,
102+
internal_analyticTag: PropTypes.string,
103103
/**
104104
* Invoked on load start
105105
*/
@@ -299,7 +299,7 @@ let Image = (props: ImagePropsType, forwardedRef) => {
299299
analyticTag !== null
300300
? {
301301
...nativeProps,
302-
analyticTag: analyticTag,
302+
internal_analyticTag: analyticTag,
303303
}
304304
: nativeProps;
305305
return (

Libraries/Image/ImageProps.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,9 @@ export type ImageProps = {|
6969
accessible?: ?boolean,
7070

7171
/**
72-
* Analytics Tag used by this Image
72+
* Internal prop to set an "Analytics Tag" that can will be set on the Image
7373
*/
74-
analyticTag?: ?string,
74+
internal_analyticTag?: ?string,
7575

7676
/**
7777
* The text that's read by the screen reader when the user interacts with

ReactAndroid/src/main/java/com/facebook/react/views/image/ReactImageManager.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,8 +124,8 @@ public void setBlurRadius(ReactImageView view, float blurRadius) {
124124
view.setBlurRadius(blurRadius);
125125
}
126126

127-
@ReactProp(name = "analyticTag")
128-
public void setAnalyticsTag(ReactImageView view, @Nullable String analyticTag) {
127+
@ReactProp(name = "internal_analyticTag")
128+
public void setInternal_AnalyticsTag(ReactImageView view, @Nullable String analyticTag) {
129129
if (mCallerContextFactory != null) {
130130
view.updateCallerContext(
131131
mCallerContextFactory.getOrCreateCallerContext(

0 commit comments

Comments
 (0)