Skip to content

Commit 619d115

Browse files
justjavacfacebook-github-bot
authored andcommitted
fix missing dll exports (#1127)
Summary: When I use libyogacore.so in other programming languages, it crash with message as > Could not obtain symbol from the library: dlsym(0x20b84d220, YGConfigIsExperimentalFeatureEnabled): symbol not found This function is defined as `WIN_EXPORT bool YGConfigIsExperimentalFeatureEnabled` in yoga.h, but is not defined using `YOGA_EXPORT` in yoga.cpp. X-link: facebook/yoga#1127 Reviewed By: yungsters Differential Revision: D40024450 Pulled By: yungsters fbshipit-source-id: f6f01eadccb13d593c68300059e96f4b0bbc9fb6
1 parent 43cf78d commit 619d115

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

ReactCommon/yoga/yoga/Yoga.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,7 @@ YOGA_EXPORT void YGNodeReset(YGNodeRef node) {
302302
node->reset();
303303
}
304304

305-
int32_t YGConfigGetInstanceCount(void) {
305+
YOGA_EXPORT int32_t YGConfigGetInstanceCount(void) {
306306
return gConfigInstanceCount;
307307
}
308308

@@ -4324,7 +4324,7 @@ YOGA_EXPORT void YGConfigSetExperimentalFeatureEnabled(
43244324
config->experimentalFeatures[feature] = enabled;
43254325
}
43264326

4327-
inline bool YGConfigIsExperimentalFeatureEnabled(
4327+
YOGA_EXPORT bool YGConfigIsExperimentalFeatureEnabled(
43284328
const YGConfigRef config,
43294329
const YGExperimentalFeature feature) {
43304330
return config->experimentalFeatures[feature];

0 commit comments

Comments
 (0)