Skip to content

Commit 3f77736

Browse files
cortinicofacebook-github-bot
authored andcommitted
RNGP - Do not set GENERATED_SRC_DIR and REACT_ANDROID_BUILD_DIR (#35101)
Summary: Pull Request resolved: #35101 Those CMake variables are effectively unused now. They're raising a warning on CMake builds of templates + let's not expose them as we haven't released RNGP yet, before libraries or other tools start relying on them. Changelog: [Internal] [Changed] - RNGP - Do not set GENERATED_SRC_DIR and REACT_ANDROID_BUILD_DIR Reviewed By: cipolleschi Differential Revision: D40751998 fbshipit-source-id: 13f54a6247e4734c21c263f8b1e6b4b9e8ba406c
1 parent 1f42ff0 commit 3f77736

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/utils/NdkConfiguratorUtils.kt

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -39,22 +39,13 @@ internal object NdkConfiguratorUtils {
3939
// Parameters should be provided in an additive manner (do not override what
4040
// the user provided, but allow for sensible defaults).
4141
val cmakeArgs = ext.defaultConfig.externalNativeBuild.cmake.arguments
42-
if ("-DGENERATED_SRC_DIR" !in cmakeArgs) {
43-
cmakeArgs.add("-DGENERATED_SRC_DIR=${File(project.buildDir, "generated/source")}")
44-
}
4542
if ("-DPROJECT_BUILD_DIR" !in cmakeArgs) {
4643
cmakeArgs.add("-DPROJECT_BUILD_DIR=${project.buildDir}")
4744
}
4845
if ("-DREACT_ANDROID_DIR" !in cmakeArgs) {
4946
cmakeArgs.add(
5047
"-DREACT_ANDROID_DIR=${extension.reactNativeDir.file("ReactAndroid").get().asFile}")
5148
}
52-
if ("-DREACT_ANDROID_BUILD_DIR" !in cmakeArgs) {
53-
cmakeArgs.add(
54-
"-DREACT_ANDROID_BUILD_DIR=${
55-
extension.reactNativeDir.file("ReactAndroid/build").get().asFile
56-
}")
57-
}
5849
if ("-DANDROID_STL" !in cmakeArgs) {
5950
cmakeArgs.add("-DANDROID_STL=c++_shared")
6051
}

0 commit comments

Comments
 (0)