Skip to content

Commit 31f2199

Browse files
arhelmusfacebook-github-bot
authored andcommitted
Disabled cpp view managers in runtime
Summary: We found this feature crashing the app during hot reload, and as there is no user code dependent on it so far, we decided to disable it until we find the root cause. changelog: [internal] internal Reviewed By: mdvacca Differential Revision: D40445312 fbshipit-source-id: fe28b58c5dca6c91389ad38675ca37669a4965a0
1 parent 55fca7f commit 31f2199

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

ReactAndroid/src/main/jni/react/fabric/Binding.cpp

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -377,9 +377,11 @@ void Binding::installFabricUIManager(
377377
<< this << ").";
378378
}
379379

380-
sharedCppComponentRegistry_ =
381-
std::shared_ptr<const facebook::react::CppComponentRegistry>(
382-
cppComponentRegistry ? cppComponentRegistry : nullptr);
380+
// TODO[T135327389]: Investigate why code relying on CppComponentRegistry
381+
// crashing during hot reload restart.
382+
// sharedCppComponentRegistry_ =
383+
// std::shared_ptr<const facebook::react::CppComponentRegistry>(
384+
// cppComponentRegistry ? cppComponentRegistry : nullptr);
383385

384386
// Use std::lock and std::adopt_lock to prevent deadlocks by locking mutexes
385387
// at the same time

0 commit comments

Comments
 (0)