Skip to content

Commit 30411ae

Browse files
Christopher Jonesfacebook-github-bot
Christopher Jones
authored andcommitted
Replace Toast with Log.w on ReactImageView when null URL specified (#34819)
Summary: Pull Request resolved: #34819 This is crashing on A12 because of using the regular Context instead of the application context. That said, this probably makes more sense as a log warning. Reviewed By: javache Differential Revision: D39852058 fbshipit-source-id: 1ac93f8cc9ecdb14f60baca175c8ecff2ff42ac0
1 parent 5f5d6b7 commit 30411ae

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

ReactAndroid/src/main/java/com/facebook/react/views/image/BUCK

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ rn_android_library(
6565
react_native_target("java/com/facebook/react/common:common"),
6666
react_native_target("java/com/facebook/react/module/annotations:annotations"),
6767
react_native_target("java/com/facebook/react/uimanager:uimanager"),
68+
react_native_target("java/com/facebook/react/util:util"),
6869
react_native_target("java/com/facebook/react/modules/fresco:fresco"),
6970
react_native_target("java/com/facebook/react/uimanager/annotations:annotations"),
7071
react_native_target("java/com/facebook/react/views/imagehelper:withmultisource"),

ReactAndroid/src/main/java/com/facebook/react/views/image/ReactImageView.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import android.graphics.drawable.Animatable;
2020
import android.graphics.drawable.Drawable;
2121
import android.net.Uri;
22-
import android.widget.Toast;
2322
import androidx.annotation.Nullable;
2423
import com.facebook.common.internal.Objects;
2524
import com.facebook.common.references.CloseableReference;
@@ -51,6 +50,7 @@
5150
import com.facebook.react.uimanager.PixelUtil;
5251
import com.facebook.react.uimanager.UIManagerHelper;
5352
import com.facebook.react.uimanager.events.EventDispatcher;
53+
import com.facebook.react.util.RNLog;
5454
import com.facebook.react.views.imagehelper.ImageSource;
5555
import com.facebook.react.views.imagehelper.MultiSourceHelper;
5656
import com.facebook.react.views.imagehelper.MultiSourceHelper.MultiSourceResult;
@@ -597,11 +597,9 @@ private boolean shouldResize(ImageSource imageSource) {
597597

598598
private void warnImageSource(String uri) {
599599
if (ReactBuildConfig.DEBUG) {
600-
Toast.makeText(
601-
getContext(),
602-
"Warning: Image source \"" + uri + "\" doesn't exist",
603-
Toast.LENGTH_SHORT)
604-
.show();
600+
RNLog.w(
601+
(ReactContext) getContext(),
602+
"ReactImageView: Image source \"" + uri + "\" doesn't exist");
605603
}
606604
}
607605
}

0 commit comments

Comments
 (0)