Skip to content

Microsoft IE/Edge doesn't seem to be pulling down client configuration settings. #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
niemyjski opened this issue Jun 16, 2015 · 2 comments

Comments

@niemyjski
Copy link
Member

I noticed this during testing that it doesn't seem to be parsing the header properly.

@niemyjski niemyjski changed the title Microsoft Edge doesn't seem to be pulling down client configuration settings. Microsoft IE/Edge doesn't seem to be pulling down client configuration settings. Oct 22, 2015
@srijken
Copy link
Contributor

srijken commented Oct 22, 2015

Also seen in IE11, didn't check older browsers.

The reason here is that XHR.getAllResponseHeaders() returns a string that doesn't confirm to the specification. The string returned in the error instance:

\nX-Exceptionless-ConfigVersion: 10\r\nX-RateLimit-Limit: 3500\r\nX-RateLimit-Remaining: 3483\r\n\r\n

The problem that causes the issue in Exceptionless.Javascript is the fact that the result of getAllResponseHeaders() starts of with '\n. That in turn causes the header to be stored like this:

headers['\nX-Exceptionless-ConfigVersion'] = 10;

Because the value is read with the extra \n, the current configVersion can't be read, and that causes the config API endpoint to never be called.

Fix is to trim the keys when we assign values to the object property.

Although the leading \n causes the problem, the trailing \r\n\r\n shouldn't be there either according to the specification

@niemyjski
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants