Fixed an issue where the dedup plugin would return and not call the next callback

@srijken plugins can’t have returns unless they call the next callback.
This has also bitten me

Author: niemyjski

.vscode/settings.json

@@ -1,4 +1,5 @@
 // Place your settings in this file to overwrite default and user settings.
 {
-  "files.insertFinalNewline": true
+"files.insertFinalNewline": true,
+"typescript.tsdk": "./node_modules/typescript/lib"
 }

dist/exceptionless.js

@@ -26,7 +26,6 @@ export class DuplicateCheckerPlugin implements IEventPlugin {
   public run(context: EventPluginContext, next?: () => void): void {
     function getHashCode(error: IInnerError): number {
       let hashCode = 0;
-
       while (error) {
         if (error.message && error.message.length) {
           hashCode += (hashCode * 397) ^ Utils.getHashCode(error.message);
@@ -42,36 +41,33 @@ export class DuplicateCheckerPlugin implements IEventPlugin {
 
     let error = context.event.data['@error'];
     let hashCode = getHashCode(error);
+    if (hashCode) {
+      let count = context.event.count || 1;
+      let now = this._getCurrentTime();
+
+      let merged = this._mergedEvents.filter(s => s.hashCode === hashCode)[0];
+      if (merged) {
+        merged.incrementCount(count);
+        merged.updateDate(context.event.date);
+        context.log.info('Ignoring duplicate event with hash: ' + hashCode);
+        context.cancelled = true;
+      }
 
-    if (!hashCode) {
-      return;
-    }
-
-    let count = context.event.count || 1;
-    let now = this._getCurrentTime();
-
-    let merged = this._mergedEvents.filter(s => s.hashCode === hashCode)[0];
-    if (merged) {
-      merged.incrementCount(count);
-      merged.updateDate(context.event.date);
-      context.log.info('Ignoring duplicate event with hash: ' + hashCode);
-      context.cancelled = true;
-      return;
-    }
-
-    if (this._processedHashcodes.some(h => h.hash === hashCode && h.timestamp >= (now - this._interval))) {
-      context.log.trace('Adding event with hash: ' + hashCode);
-      this._mergedEvents.push(new MergedEvent(hashCode, context, count));
-      context.cancelled = true;
-      return;
-    }
+      if (!context.cancelled && this._processedHashcodes.some(h => h.hash === hashCode && h.timestamp >= (now - this._interval))) {
+        context.log.trace('Adding event with hash: ' + hashCode);
+        this._mergedEvents.push(new MergedEvent(hashCode, context, count));
+        context.cancelled = true;
+      }
 
-    context.log.trace('Enqueueing event with hash: ' + hashCode + 'to cache.');
-    this._processedHashcodes.push({ hash: hashCode, timestamp: now });
+      if (!context.cancelled) {
+        context.log.trace('Enqueueing event with hash: ' + hashCode + 'to cache.');
+        this._processedHashcodes.push({ hash: hashCode, timestamp: now });
 
-    // Only keep the last 50 recent errors.
-    while (this._processedHashcodes.length > 50) {
-      this._processedHashcodes.shift();
+        // Only keep the last 50 recent errors.
+        while (this._processedHashcodes.length > 50) {
+          this._processedHashcodes.shift();
+        }
+      }
     }
 
     next && next();