Finished updating listing settings

Author: niemyjski

package.json

@@ -52,7 +52,7 @@
     "gulp-tslint": "8.0.0",
     "gulp-uglify": "2.1.2",
     "gulp-wrap-umd": "0.2.1",
-    "jshint": "^2.9.4",
+    "jshint": "2.9.4",
     "mock-fs": "4.2.0",
     "path": "0.12.7",
     "requirejs": "2.3.3",

src/EventBuilder.ts

@@ -84,7 +84,8 @@ export class EventBuilder {
     return this;
   }
 
-  public setUserIdentity(userInfo: IUserInfo | string): EventBuilder;
+  public setUserIdentity(userInfo: IUserInfo): EventBuilder;
+  public setUserIdentity(identity: string): EventBuilder;
   public setUserIdentity(identity: string, name: string): EventBuilder;
   public setUserIdentity(userInfoOrIdentity: IUserInfo | string, name?: string): EventBuilder {
     const userInfo = typeof userInfoOrIdentity !== 'string' ? userInfoOrIdentity : { identity: userInfoOrIdentity, name };

src/Utils.ts

@@ -8,9 +8,9 @@ export class Utils {
       return target;
     }
 
-    for (let index = 0; index < values.length; index++) {
-      if (values[index] && target.indexOf(values[index]) < 0) {
-        target.push(values[index]);
+    for (const value of values) {
+      if (value && target.indexOf(value) < 0) {
+        target.push(value);
       }
     }
 
@@ -32,12 +32,12 @@ export class Utils {
     return hash;
   }
 
-  public static getCookies(cookies: string, exclusions?: string[]): Object {
-    const result: Object = {};
+  public static getCookies(cookies: string, exclusions?: string[]): object {
+    const result: object = {};
 
     const parts: string[] = (cookies || '').split('; ');
-    for (let index = 0; index < parts.length; index++) {
-      const cookie: string[] = parts[index].split('=');
+    for (const part of parts) {
+      const cookie: string[] = part.split('=');
       if (!Utils.isMatch(cookie[0], exclusions)) {
         result[cookie[0]] = cookie[1];
       }
@@ -54,8 +54,9 @@ export class Utils {
     return s4() + s4() + '-' + s4() + '-' + s4() + '-' + s4() + '-' + s4() + s4() + s4();
   }
 
+  // tslint:disable-next-line:ban-types
   public static merge(defaultValues: Object, values: Object) {
-    const result: Object = {};
+    const result: object = {};
 
     for (const key in defaultValues || {}) {
       if (!!defaultValues[key]) {
@@ -96,11 +97,11 @@ export class Utils {
       return null;
     }
 
-    const result: Object = {};
-    for (let index = 0; index < pairs.length; index++) {
-      const pair = pairs[index].split('=');
-      if (!Utils.isMatch(pair[0], exclusions)) {
-        result[decodeURIComponent(pair[0])] = decodeURIComponent(pair[1]);
+    const result: object = {};
+    for (const pair of pairs) {
+      const parts = pair.split('=');
+      if (!Utils.isMatch(parts[0], exclusions)) {
+        result[decodeURIComponent(parts[0])] = decodeURIComponent(parts[1]);
       }
     }
 
@@ -160,7 +161,7 @@ export class Utils {
     });
   }
 
-  public static isEmpty(input: Object) {
+  public static isEmpty(input: object) {
     return input === null || (typeof (input) === 'object' && Object.keys(input).length === 0);
   }
 
@@ -181,7 +182,7 @@ export class Utils {
   public static stringify(data: any, exclusions?: string[], maxDepth?: number): string {
     function stringifyImpl(obj: any, excludedKeys: string[]): string {
       const cache: string[] = [];
-      return JSON.stringify(obj, function(key: string, value: any) {
+      return JSON.stringify(obj, (key: string, value: any) => {
         if (Utils.isMatch(key, excludedKeys)) {
           return;
         }

src/configuration/Configuration.ts

@@ -46,7 +46,7 @@ export class Configuration implements IConfigurationSettings {
    *
    * @type {{}}
    */
-  public defaultData: Object = {};
+  public defaultData: object = {};
 
   /**
    * Whether the client is currently enabled or not. If it is disabled,
@@ -74,7 +74,7 @@ export class Configuration implements IConfigurationSettings {
    * Contains a dictionary of custom settings that can be used to control
    * the client and will be automatically updated from the server.
    */
-  public settings: Object = {};
+  public settings: object = {};
 
   public storage: IStorageProvider;
 
@@ -134,7 +134,7 @@ export class Configuration implements IConfigurationSettings {
    * @type {Array}
    * @private
    */
-  private _handlers: Array<{ (config: Configuration): void }> = [];
+  private _handlers: Array<(config: Configuration) => void> = [];
 
   constructor(configSettings?: IConfigurationSettings) {
     function inject(fn: any) {
@@ -349,8 +349,8 @@ export class Configuration implements IConfigurationSettings {
 
     let pluginExists: boolean = false;
     const plugins = this._plugins; // optimization for minifier.
-    for (let index = 0; index < plugins.length; index++) {
-      if (plugins[index].name === plugin.name) {
+    for (const p of plugins) {
+      if (p.name === plugin.name) {
         pluginExists = true;
         break;
       }
@@ -371,7 +371,6 @@ export class Configuration implements IConfigurationSettings {
    * Remove an plugin by key from this configuration.
    * @param name
    */
-  public removePlugin(name: string): void;
   public removePlugin(pluginOrName: IEventPlugin | string): void {
     const name: string = typeof pluginOrName === 'string' ? pluginOrName : pluginOrName.name;
     if (!name) {
@@ -454,9 +453,9 @@ export class Configuration implements IConfigurationSettings {
 
   private changed() {
     const handlers = this._handlers; // optimization for minifier.
-    for (let index = 0; index < handlers.length; index++) {
+    for (const handler of handlers) {
       try {
-        handlers[index](this);
+        handler(this);
       } catch (ex) {
         this.log.error(`Error calling onChanged handler: ${ex}`);
       }

src/configuration/SettingsManager.ts

@@ -13,7 +13,7 @@ export class SettingsManager {
    * @type {Array}
    * @private
    */
-  private static _handlers: Array<{ (config: Configuration): void }> = [];
+  private static _handlers: Array<(config: Configuration) => void> = [];
 
   public static onChanged(handler: (config: Configuration) => void) {
     !!handler && this._handlers.push(handler);
@@ -54,7 +54,7 @@ export class SettingsManager {
       return;
     }
 
-    let unableToUpdateMessage = 'Unable to update settings';
+    const unableToUpdateMessage = 'Unable to update settings';
     if (!config.isValid) {
       config.log.error(`${unableToUpdateMessage}: ApiKey is not set.`);
       return;
@@ -98,9 +98,9 @@ export class SettingsManager {
 
   private static changed(config: Configuration) {
     const handlers = this._handlers; // optimization for minifier.
-    for (let index = 0; index < handlers.length; index++) {
+    for (const handler of handlers) {
       try {
-        handlers[index](config);
+        handler(config);
       } catch (ex) {
         config.log.error(`Error calling onChanged handler: ${ex}`);
       }

src/exceptionless.node.ts

@@ -50,21 +50,21 @@ function onUncaughtException(callback: (error: Error) => void) {
   };
 }
 
-onUncaughtException(function(error: Error) {
+onUncaughtException((error: Error) => {
   ExceptionlessClient.default.submitUnhandledException(error, UNCAUGHT_EXCEPTION);
 });
 
 /*
  * We cannot hijack SIGINT, so if there are no other handlers,
  * we just reproduce default Node.js behavior by exiting.
  */
-process.on(SIGINT, function() {
+process.on(SIGINT, () => {
   if (getListenerCount(process, SIGINT) <= 1) {
     process.exit(128 + SIGINT_CODE);
   }
 });
 
-process.on(EXIT, function(code: number) {
+process.on(EXIT, (code: number) => {
   /**
    * exit codes: https://nodejs.org/api/process.html#process_event_exit
    * From now on, only synchronous code may run. As soon as this method
@@ -125,4 +125,4 @@ process.on(EXIT, function(code: number) {
   // Application will now exit.
 });
 
-(<any>Error).stackTraceLimit = Infinity;
+(Error as any).stackTraceLimit = Infinity;

src/exceptionless.ts

@@ -17,6 +17,7 @@ function getDefaultsSettingsFromScriptTag(): IConfigurationSettings {
   }
 
   const scripts = document.getElementsByTagName('script');
+  // tslint:disable-next-line:prefer-for-of
   for (let index = 0; index < scripts.length; index++) {
     if (scripts[index].src && scripts[index].src.indexOf('/exceptionless') > -1) {
       return Utils.parseQueryString(scripts[index].src.split('?').pop());
@@ -79,6 +80,7 @@ TraceKit.extendToAsynchronousCallbacks();
 //   $(document).ajaxError(processJQueryAjaxError);
 // }
 
-(<any>Error).stackTraceLimit = Infinity;
+(Error as any).stackTraceLimit = Infinity;
 
+// tslint:disable-next-line:prefer-const
 declare var $;

src/integrations/angular.ts

@@ -4,7 +4,7 @@ declare var exceptionless;
 
 angular.module('exceptionless', [])
   .constant('$ExceptionlessClient', exceptionless.ExceptionlessClient.default)
-  .factory('exceptionlessHttpInterceptor', ['$q', '$ExceptionlessClient', function($q, $ExceptionlessClient) {
+  .factory('exceptionlessHttpInterceptor', ['$q', '$ExceptionlessClient', ($q, $ExceptionlessClient) => {
     return {
       responseError: function responseError(rejection) {
         if (rejection.status === 404) {
@@ -21,28 +21,29 @@ angular.module('exceptionless', [])
       }
     };
   }])
-  .config(['$httpProvider', '$provide', '$ExceptionlessClient', function($httpProvider, $provide, $ExceptionlessClient) {
+  .config(['$httpProvider', '$provide', '$ExceptionlessClient', ($httpProvider, $provide, $ExceptionlessClient) => {
     $httpProvider.interceptors.push('exceptionlessHttpInterceptor');
-    $provide.decorator('$exceptionHandler', ['$delegate', function($delegate) {
-      return function(exception, cause) {
+    $provide.decorator('$exceptionHandler', ['$delegate', ($delegate) => {
+      return (exception, cause) => {
         $delegate(exception, cause);
         $ExceptionlessClient.createUnhandledException(exception, '$exceptionHandler').setMessage(cause).submit();
       };
     }]);
-    $provide.decorator('$log', ['$delegate', function($delegate) {
+    $provide.decorator('$log', ['$delegate', ($delegate) => {
       function decorateRegularCall(property, logLevel) {
         const previousFn = $delegate[property];
-        return $delegate[property] = function() {
+        return $delegate[property] = (...args) => {
           if (angular.mock) {
             // Needed to support angular-mocks.
             $delegate[property].logs = [];
           }
-          previousFn.apply(null, arguments);
-          if (arguments[0] && arguments[0].length > 0) {
-            $ExceptionlessClient.submitLog(null, arguments[0], logLevel);
+          previousFn.apply(null, args);
+          if (args[0] && args[0].length > 0) {
+            $ExceptionlessClient.submitLog(null, args[0], logLevel);
           }
         };
       }
+
       $delegate.log = decorateRegularCall('log', 'Trace');
       $delegate.info = decorateRegularCall('info', 'Info');
       $delegate.warn = decorateRegularCall('warn', 'Warn');
@@ -51,8 +52,8 @@ angular.module('exceptionless', [])
       return $delegate;
     }]);
   }])
-  .run(['$rootScope', '$ExceptionlessClient', function($rootScope, $ExceptionlessClient) {
-    $rootScope.$on('$routeChangeSuccess', function(event, next, current) {
+  .run(['$rootScope', '$ExceptionlessClient', ($rootScope, $ExceptionlessClient) => {
+    $rootScope.$on('$routeChangeSuccess', (event, next, current) => {
       if (!current) {
         return;
       }
@@ -63,14 +64,14 @@ angular.module('exceptionless', [])
         .submit();
     });
 
-    $rootScope.$on('$routeChangeError', function(event, current, previous, rejection) {
+    $rootScope.$on('$routeChangeError', (event, current, previous, rejection) => {
       $ExceptionlessClient.createUnhandledException(new Error(rejection), '$routeChangeError')
         .setProperty('current', current)
         .setProperty('previous', previous)
         .submit();
     });
 
-    $rootScope.$on('$stateChangeSuccess', function(event, toState, toParams, fromState, fromParams) {
+    $rootScope.$on('$stateChangeSuccess', (event, toState, toParams, fromState, fromParams) => {
       if (!toState || toState.name === 'otherwise') {
         return;
       }
@@ -83,7 +84,7 @@ angular.module('exceptionless', [])
         .submit();
     });
 
-    $rootScope.$on('$stateNotFound', function(event, unfoundState, fromState, fromParams) {
+    $rootScope.$on('$stateNotFound', (event, unfoundState, fromState, fromParams) => {
       if (!unfoundState) {
         return;
       }
@@ -95,8 +96,8 @@ angular.module('exceptionless', [])
         .submit();
     });
 
-    let stateChangeError = '$stateChangeError';
-    $rootScope.$on(stateChangeError, function(event, toState, toParams, fromState, fromParams, error) {
+    const stateChangeError = '$stateChangeError';
+    $rootScope.$on(stateChangeError, (event, toState, toParams, fromState, fromParams, error) => {
       if (!error) {
         return;
       }
@@ -111,7 +112,7 @@ angular.module('exceptionless', [])
         .submit();
     });
 
-    $rootScope.$on('$destroy', function() {
+    $rootScope.$on('$destroy', () => {
       $ExceptionlessClient.config.queue.process();
     });
   }]);

src/logging/ConsoleLog.ts

@@ -19,7 +19,7 @@ export class ConsoleLog implements ILog {
 
   private log(level: string, message: string) {
     if (console) {
-      let msg = `[${level}] Exceptionless: ${message}`;
+      const msg = `[${level}] Exceptionless: ${message}`;
 
       if (console[level]) {
         console[level](msg);

src/plugins/EventPluginManager.ts

@@ -12,7 +12,7 @@ import { IEventPlugin } from './IEventPlugin';
 
 export class EventPluginManager {
   public static run(context: EventPluginContext, callback: (context?: EventPluginContext) => void): void {
-    const wrap = function(plugin: IEventPlugin, next?: () => void): () => void {
+    const wrap = (plugin: IEventPlugin, next?: () => void): () => void => {
       return () => {
         try {
           if (!context.cancelled) {
@@ -30,7 +30,7 @@ export class EventPluginManager {
     };
 
     const plugins: IEventPlugin[] = context.client.config.plugins; // optimization for minifier.
-    const wrappedPlugins: { (): void }[] = [];
+    const wrappedPlugins: Array<() => void> = [];
     if (!!callback) {
       wrappedPlugins[plugins.length] = wrap({ name: 'cb', priority: 9007199254740992, run: callback }, null);
     }

src/plugins/default/ConfigurationDefaultsPlugin.ts

@@ -9,14 +9,14 @@ export class ConfigurationDefaultsPlugin implements IEventPlugin {
   public run(context: EventPluginContext, next?: () => void): void {
     const config = context.client.config;
     const defaultTags: string[] = config.defaultTags || [];
-    for (let index = 0; index < defaultTags.length; index++) {
-      const tag = defaultTags[index];
+    for (const tag of defaultTags) {
       if (!!tag && context.event.tags.indexOf(tag) < 0) {
         context.event.tags.push(tag);
       }
     }
 
-    const defaultData: object = config.defaultData || {};
+    // tslint:disable-next-line:ban-types
+    const defaultData: Object = config.defaultData || {};
     for (const key in defaultData) {
       if (!!defaultData[key]) {
         const result = JSON.parse(Utils.stringify(defaultData[key], config.dataExclusions));

src/plugins/default/EventExclusionPlugin.ts

@@ -39,7 +39,8 @@ export class EventExclusionPlugin implements IEventPlugin {
       return getLogLevel(getTypeAndSourceSetting(settings, 'log', loggerName, 'Trace') + '');
     }
 
-    function getTypeAndSourceSetting(settings: object = {}, type: string, source: string, defaultValue: string|boolean = undefined): string|boolean {
+    // tslint:disable-next-line:ban-types
+    function getTypeAndSourceSetting(settings: Object = {}, type: string, source: string, defaultValue?: string|boolean): string|boolean {
       if (!type) {
         return defaultValue;
       }