Added unit tests for toBoolean

Author: niemyjski

dist/exceptionless.d.ts

@@ -189,7 +189,7 @@ export declare class Utils {
     static startsWith(input: string, prefix: string): boolean;
     static endsWith(input: string, suffix: string): boolean;
     static stringify(data: any, exclusions?: string[], maxDepth?: number): string;
-    static toBoolean(input: any): boolean;
+    static toBoolean(input: any, defaultValue?: boolean): boolean;
 }
 export declare class Configuration implements IConfigurationSettings {
     private static _defaultSettings;

dist/exceptionless.js

@@ -270,4 +270,50 @@ describe('Utils', () => {
       expect(Utils.endsWith('test', 'nopattern')).to.be.false;
     });
   });
+
+  describe('toBoolean', () => {
+    it('input: blake', () => {
+      expect(Utils.toBoolean('blake')).to.be.false;
+    });
+
+    it('input: 0', () => {
+      expect(Utils.toBoolean('0')).to.be.false;
+    });
+
+    it('input: no', () => {
+      expect(Utils.toBoolean('no')).to.be.false;
+    });
+
+    it('input: false', () => {
+      expect(Utils.toBoolean('false')).to.be.false;
+    });
+
+    it('input: false', () => {
+      expect(Utils.toBoolean(false)).to.be.false;
+    });
+
+    it('input: undefined', () => {
+      expect(Utils.toBoolean(undefined)).to.be.false;
+    });
+
+    it('input: null', () => {
+      expect(Utils.toBoolean(null)).to.be.false;
+    });
+
+    it('input: 1', () => {
+      expect(Utils.toBoolean('1')).to.be.true;
+    });
+
+    it('input: yes', () => {
+      expect(Utils.toBoolean('yes')).to.be.true;
+    });
+
+    it('input: true', () => {
+      expect(Utils.toBoolean('true')).to.be.true;
+    });
+
+    it('input: true', () => {
+      expect(Utils.toBoolean(true)).to.be.true;
+    });
+  });
 });

dist/exceptionless.js.map

@@ -226,15 +226,20 @@ export class Utils {
     return stringifyImpl(data, exclusions);
   }
 
-  public static toBoolean(input): boolean {
-    if (!input || !input.toLowerCase) {
-      return !!input;
+  public static toBoolean(input, defaultValue: boolean = false): boolean {
+    if (typeof input === 'boolean') {
+      return input;
     }
 
-    switch (input.toLowerCase().trim()) {
+    if (input === null || typeof input !== 'number' && typeof input !== 'string') {
+      return defaultValue;
+    }
+
+    switch ((input + '').toLowerCase().trim()) {
       case 'true': case 'yes': case '1': return true;
       case 'false': case 'no': case '0': case null: return false;
-      default: return Boolean(input);
     }
+
+    return defaultValue;
   }
 }