Skip to content

Commit ecea1f4

Browse files
committed
put back comment that was removed
1 parent 9092a1b commit ecea1f4

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

internal/linker/linker.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -470,6 +470,10 @@ func (c *linkerContext) enforceNoCyclicChunkImports() {
470470
colors[chunkIndex] = 1
471471

472472
for _, chunkImport := range c.chunks[chunkIndex].crossChunkImports {
473+
// Ignore cycles caused by dynamic "import()" expressions. These are fine
474+
// because they don't necessarily cause initialization order issues and
475+
// they don't indicate a bug in our chunk generation algorithm. They arise
476+
// normally in real code (e.g. two files that import each other).
473477
if chunkImport.importKind != ast.ImportDynamic {
474478

475479
// Recursively validate otherChunkIndex

0 commit comments

Comments
 (0)