don't try to correct CSS variables to properties

Author: evanw

internal/css_ast/css_decl_table.go

@@ -1,6 +1,10 @@
 package css_ast
 
-import "github.com/evanw/esbuild/internal/helpers"
+import (
+	"strings"
+
+	"github.com/evanw/esbuild/internal/helpers"
+)
 
 type D uint16
 
@@ -646,6 +650,10 @@ var KnownDeclarations = map[string]D{
 var typoDetector *helpers.TypoDetector
 
 func MaybeCorrectDeclarationTypo(text string) (string, bool) {
+	if strings.HasPrefix(text, "--") {
+		// Ignore CSS variables, which should not be corrected to CSS properties
+		return "", false
+	}
 	if typoDetector == nil {
 		// Lazily-initialize the typo detector for speed when it's not needed
 		valid := make([]string, 0, len(KnownDeclarations))

internal/css_parser/css_parser_test.go

@@ -1676,3 +1676,14 @@ func TestWarningUnexpectedCloseBrace(t *testing.T) {
 }
 `)
 }
+
+func TestPropertyTypoWarning(t *testing.T) {
+	expectParseError(t, "a { z-idnex: 0 }", "<stdin>: WARNING: \"z-idnex\" is not a known CSS property\nNOTE: Did you mean \"z-index\" instead?\n")
+	expectParseError(t, "a { x-index: 0 }", "<stdin>: WARNING: \"x-index\" is not a known CSS property\nNOTE: Did you mean \"z-index\" instead?\n")
+
+	// CSS variables should not be corrected
+	expectParseError(t, "a { --index: 0 }", "")
+
+	// Short names should not be corrected ("alt" is actually valid in WebKit, and should not become "all")
+	expectParseError(t, "a { alt: \"\" }", "")
+}

internal/helpers/typos.go

@@ -11,7 +11,7 @@ func MakeTypoDetector(valid []string) TypoDetector {
 
 	// Add all combinations of each valid word with one character missing
 	for _, correct := range valid {
-		if len(correct) > 2 {
+		if len(correct) > 3 {
 			for i, ch := range correct {
 				detector.oneCharTypos[correct[:i]+correct[i+utf8.RuneLen(ch):]] = correct
 			}