chore: resolve git comments

Author: evakravi

src/sagemaker/jumpstart/cache.py

@@ -205,29 +205,29 @@ def _get_manifest_key_from_model_id_semantic_version(
             sm_version_to_use = sm_version_to_use_list[0]
 
             error_msg = (
-                f"Unable to find model manifest for {model_id} with version {version} "
-                f"compatible with your SageMaker version ({sm_version}). "
+                f"Unable to find model manifest for '{model_id}' with version '{version}' "
+                f"compatible with your SageMaker version ('{sm_version}'). "
                 f"Consider upgrading your SageMaker library to at least version "
-                f"{sm_version_to_use} so you can use version "
-                f"{model_version_to_use_incompatible_with_sagemaker} of {model_id}."
+                f"'{sm_version_to_use}' so you can use version "
+                f"'{model_version_to_use_incompatible_with_sagemaker}' of '{model_id}'."
             )
             raise KeyError(error_msg)
 
-        error_msg = f"Unable to find model manifest for {model_id} with version {version}. "
+        error_msg = f"Unable to find model manifest for '{model_id}' with version '{version}'. "
 
         other_model_id_version = self._select_version(
             "*", versions_incompatible_with_sagemaker
-        )
+        )  # all versions here are incompatible with sagemaker
         if other_model_id_version is not None:
             error_msg += (
-                f"Consider using model id {model_id} with version "
-                f"{other_model_id_version}."
+                f"Consider using model ID '{model_id}' with version "
+                f"'{other_model_id_version}'."
             )
 
         else:
             possible_model_ids = [header.model_id for header in manifest.values()]
             closest_model_id = get_close_matches(model_id, possible_model_ids, n=1, cutoff=0)[0]
-            error_msg += f"Did you mean to use model id {closest_model_id}?"
+            error_msg += f"Did you mean to use model ID '{closest_model_id}'?"
 
         raise KeyError(error_msg)
 

src/sagemaker/jumpstart/types.py

@@ -135,12 +135,12 @@ def from_json(self, json_obj: Dict[str, str]) -> None:
 class JumpStartECRSpecs(JumpStartDataHolderType):
     """Data class for JumpStart ECR specs."""
 
-    __slots__ = {
+    __slots__ = [
         "framework",
         "framework_version",
         "py_version",
         "huggingface_transformers_version",
-    }
+    ]
 
     def __init__(self, spec: Dict[str, Any]):
         """Initializes a JumpStartECRSpecs object from its json representation.
@@ -173,7 +173,7 @@ def to_json(self) -> Dict[str, Any]:
 class JumpStartHyperparameter(JumpStartDataHolderType):
     """Data class for JumpStart hyperparameter definition in the training container."""
 
-    __slots__ = {
+    __slots__ = [
         "name",
         "type",
         "options",
@@ -183,7 +183,7 @@ class JumpStartHyperparameter(JumpStartDataHolderType):
         "max",
         "exclusive_min",
         "exclusive_max",
-    }
+    ]
 
     def __init__(self, spec: Dict[str, Any]):
         """Initializes a JumpStartHyperparameter object from its json representation.
@@ -234,12 +234,12 @@ def to_json(self) -> Dict[str, Any]:
 class JumpStartEnvironmentVariable(JumpStartDataHolderType):
     """Data class for JumpStart environment variable definitions in the hosting container."""
 
-    __slots__ = {
+    __slots__ = [
         "name",
         "type",
         "default",
         "scope",
-    }
+    ]
 
     def __init__(self, spec: Dict[str, Any]):
         """Initializes a JumpStartEnvironmentVariable object from its json representation.

tests/unit/sagemaker/jumpstart/test_cache.py

@@ -151,35 +151,35 @@ def test_jumpstart_cache_get_header():
             semantic_version_str="3.*",
         )
     assert (
-        "Unable to find model manifest for tensorflow-ic-imagenet-inception-v3-classification-4 "
-        "with version 3.* compatible with your SageMaker version (2.68.3). Consider upgrading "
-        "your SageMaker library to at least version 4.49.0 so you can use version 3.0.0 of "
-        "tensorflow-ic-imagenet-inception-v3-classification-4." in str(e.value)
+        "Unable to find model manifest for 'tensorflow-ic-imagenet-inception-v3-classification-4' "
+        "with version '3.*' compatible with your SageMaker version ('2.68.3'). Consider upgrading "
+        "your SageMaker library to at least version '4.49.0' so you can use version '3.0.0' of "
+        "'tensorflow-ic-imagenet-inception-v3-classification-4'." in str(e.value)
     )
 
     with pytest.raises(KeyError) as e:
         cache.get_header(
             model_id="pytorch-ic-imagenet-inception-v3-classification-4", semantic_version_str="3.*"
         )
     assert (
-        "Unable to find model manifest for pytorch-ic-imagenet-inception-v3-classification-4 with "
-        "version 3.*. Consider using model id pytorch-ic-imagenet-inception-v3-classification-4 with "
-        "version 2.0.0."
+        "Unable to find model manifest for 'pytorch-ic-imagenet-inception-v3-classification-4' with "
+        "version '3.*'. Consider using model ID 'pytorch-ic-imagenet-inception-v3-classification-4' with "
+        "version '2.0.0'."
     ) in str(e.value)
 
     with pytest.raises(KeyError) as e:
         cache.get_header(model_id="pytorch-ic-", semantic_version_str="*")
     assert (
-        "Unable to find model manifest for pytorch-ic- with version *. "
-        "Did you mean to use model id pytorch-ic-imagenet-inception-v3-classification-4?"
+        "Unable to find model manifest for 'pytorch-ic-' with version '*'. "
+        "Did you mean to use model ID 'pytorch-ic-imagenet-inception-v3-classification-4'?"
     ) in str(e.value)
 
     with pytest.raises(KeyError) as e:
         cache.get_header(model_id="tensorflow-ic-", semantic_version_str="*")
     assert (
-        "Unable to find model manifest for tensorflow-ic- with version *. "
-        "Did you mean to use model id tensorflow-ic-imagenet-inception-"
-        "v3-classification-4?"
+        "Unable to find model manifest for 'tensorflow-ic-' with version '*'. "
+        "Did you mean to use model ID 'tensorflow-ic-imagenet-inception-"
+        "v3-classification-4'?"
     ) in str(e.value)
 
     with pytest.raises(KeyError):