From 33296620fd01742498ac1ca48d1f22b9a42f8fbf Mon Sep 17 00:00:00 2001
From: "sanket.wadekar" <sanket.wadekar@espressif.com>
Date: Tue, 13 Dec 2022 13:50:30 +0530
Subject: [PATCH] Added Insights configs to common defs

---
 configs/builds.json        |  2 +-
 configs/defconfig.common   | 18 ++++++++++++++++++
 configs/defconfig.insights | 27 ---------------------------
 3 files changed, 19 insertions(+), 28 deletions(-)
 delete mode 100644 configs/defconfig.insights

diff --git a/configs/builds.json b/configs/builds.json
index e84cc3430..c32e465e4 100644
--- a/configs/builds.json
+++ b/configs/builds.json
@@ -98,7 +98,7 @@
 		},
 		{
 			"target": "esp32",
-			"features":["qio_ram","insights"],
+			"features":["qio_ram"],
 			"idf_libs":["qio","80m"],
 			"bootloaders":[
 				["qio","80m"],
diff --git a/configs/defconfig.common b/configs/defconfig.common
index 0cf4b823c..cbcfd8d2c 100644
--- a/configs/defconfig.common
+++ b/configs/defconfig.common
@@ -74,3 +74,21 @@ CONFIG_SPIRAM_MALLOC_RESERVE_INTERNAL=0
 CONFIG_LWIP_IPV6_AUTOCONFIG=y
 CONFIG_ESP_RMAKER_SKIP_VERSION_CHECK=y
 CONFIG_ESP_RMAKER_USER_ID_CHECK=y
+CONFIG_ESP_INSIGHTS_ENABLED=y
+CONFIG_ESP_INSIGHTS_COREDUMP_ENABLE=y
+CONFIG_ESP_INSIGHTS_TRANSPORT_HTTPS=y
+CONFIG_DIAG_LOG_DROP_WIFI_LOGS=y
+CONFIG_DIAG_ENABLE_METRICS=y
+CONFIG_DIAG_ENABLE_HEAP_METRICS=y
+CONFIG_DIAG_ENABLE_WIFI_METRICS=y
+CONFIG_DIAG_ENABLE_VARIABLES=y
+CONFIG_DIAG_ENABLE_NETWORK_VARIABLES=y
+CONFIG_ESP_COREDUMP_ENABLE=y
+CONFIG_ESP_COREDUMP_ENABLE_TO_FLASH=y
+CONFIG_ESP_COREDUMP_DATA_FORMAT_ELF=y
+CONFIG_ESP_COREDUMP_CHECKSUM_CRC32=y
+CONFIG_ESP_COREDUMP_MAX_TASKS_NUM=64
+CONFIG_ESP_COREDUMP_STACK_SIZE=1024
+CONFIG_MBEDTLS_DYNAMIC_BUFFER=y
+CONFIG_MBEDTLS_DYNAMIC_FREE_PEER_CERT=y
+CONFIG_MBEDTLS_DYNAMIC_FREE_CONFIG_DATA=y
diff --git a/configs/defconfig.insights b/configs/defconfig.insights
deleted file mode 100644
index eb5d6ac43..000000000
--- a/configs/defconfig.insights
+++ /dev/null
@@ -1,27 +0,0 @@
-CONFIG_ESP_INSIGHTS_ENABLED=y
-# CONFIG_ESP_INSIGHTS_DEBUG_ENABLED is not set
-CONFIG_ESP_INSIGHTS_COREDUMP_ENABLE=y
-# CONFIG_ESP_INSIGHTS_TRANSPORT_MQTT is not set
-CONFIG_ESP_INSIGHTS_TRANSPORT_HTTPS=y
-
-CONFIG_DIAG_ENABLE_METRICS=y
-CONFIG_DIAG_ENABLE_WIFI_METRICS=y
-CONFIG_DIAG_ENABLE_HEAP_METRICS=y
-CONFIG_DIAG_ENABLE_VARIABLES=y
-CONFIG_DIAG_ENABLE_NETWORK_VARIABLES=y
-
-CONFIG_ESP32_ENABLE_COREDUMP=y
-CONFIG_ESP32_ENABLE_COREDUMP_TO_FLASH=y
-CONFIG_ESP32_COREDUMP_DATA_FORMAT_ELF=y
-CONFIG_ESP32_COREDUMP_CHECKSUM_CRC32=y
-CONFIG_ESP32_CORE_DUMP_MAX_TASKS_NUM=64
-CONFIG_ESP32_CORE_DUMP_STACK_SIZE=1024
-
-CONFIG_MBEDTLS_DYNAMIC_BUFFER=y
-CONFIG_MBEDTLS_DYNAMIC_FREE_PEER_CERT=y
-CONFIG_MBEDTLS_DYNAMIC_FREE_CONFIG_DATA=y
-
-CONFIG_PARTITION_TABLE_CUSTOM_FILENAME="partitions.csv"
-CONFIG_PARTITION_TABLE_FILENAME="partitions.csv"
-CONFIG_PARTITION_TABLE_OFFSET=0x8000
-CONFIG_PARTITION_TABLE_MD5=y
\ No newline at end of file