Skip to content

Commit 1cf54a3

Browse files
committed
Change parameter name
1 parent 36acb43 commit 1cf54a3

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

tools/config_editor/app.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ class ConfigEditorApp(App):
103103
# Options to be set by the command line arguments
104104
setting_target = ""
105105
setting_arduino_path = ""
106-
setting_arduino_permissions = ""
106+
setting_output_permissions = ""
107107
setting_arduino_branch = ""
108108
setting_idf_branch = ""
109109
setting_idf_commit = ""
@@ -200,7 +200,7 @@ def main() -> None:
200200
required=False,
201201
help="Path to arduino-esp32 directory. Default: " + arduino_default_path())
202202

203-
parser.add_argument("-p", "--arduino-permissions",
203+
parser.add_argument("--output-permissions",
204204
metavar="<uid:gid>",
205205
type=str,
206206
default="",
@@ -275,7 +275,7 @@ def main() -> None:
275275

276276
# Set the other options
277277
app.setting_arduino_path = os.path.abspath(args.arduino_path)
278-
app.setting_arduino_permissions = args.arduino_permissions
278+
app.setting_output_permissions = args.output_permissions
279279
app.setting_arduino_branch = args.arduino_branch
280280
app.setting_idf_branch = args.idf_branch
281281
app.setting_idf_commit = args.idf_commit

tools/config_editor/compile.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,11 +140,11 @@ def compile_libs(self) -> None:
140140
label.update("Compilation failed for " + target)
141141
else:
142142
regex = r"^[1-9][0-9]*:[1-9][0-9]*$" # Regex to match the uid:gid format
143-
if self.app.setting_arduino_permissions and re.match(regex, self.app.setting_arduino_permissions):
143+
if self.app.setting_output_permissions and re.match(regex, self.app.setting_output_permissions):
144144
print_info("Changing permissions of generated files")
145145
chown_process = None
146146
try:
147-
chown_process = subprocess.run(["chown", "-R", self.app.setting_arduino_permissions, self.app.setting_arduino_path])
147+
chown_process = subprocess.run(["chown", "-R", self.app.setting_output_permissions, self.app.setting_arduino_path])
148148
chown_process.wait()
149149
except Exception as e:
150150
print("Error changing permissions: " + str(e))

tools/docker/entrypoint.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ fi
1717

1818
# Check if the mount point /arduino-esp32 exists
1919
if [ -d "/arduino-esp32" ] && [[ "$@" == "python3 tools/config_editor/app.py"* ]]; then
20-
# Running UI with mount point detected, adding -p and -c arguments
21-
exec "$@" -c /arduino-esp32 -p `stat -c "%u:%g" /arduino-esp32`
20+
# Running UI with mount point detected, adding -c and --output-permissions arguments
21+
exec "$@" -c /arduino-esp32 --output-permissions `stat -c "%u:%g" /arduino-esp32`
2222
else
2323
# Running UI without mount point detected or running another command
2424
exec "$@"

0 commit comments

Comments
 (0)