Skip to content

Commit a0644bf

Browse files
committed
Merge branch 'test/resume_ut_esp32s2' into 'master'
ci: resume esp32s2 unit tests See merge request espressif/esp-idf!7436
2 parents a6066c8 + 2529eda commit a0644bf

File tree

18 files changed

+68
-28
lines changed

18 files changed

+68
-28
lines changed

components/app_update/test/test_ota_ops.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ TEST_CASE("esp_ota_get_next_update_partition logic", "[ota]")
8484
TEST_ASSERT_EQUAL_PTR(ota_0, p);
8585
}
8686

87-
TEST_CASE("esp_ota_get_partition_description ", "[ota]")
87+
TEST_CASE("esp_ota_get_partition_description", "[ota]")
8888
{
8989
const esp_partition_t *running = esp_ota_get_running_partition();
9090
TEST_ASSERT_NOT_NULL(running);

components/driver/test/test_ledc.c

+4-1
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,9 @@
3131
#define HIGHEST_LIMIT 10000
3232
#define LOWEST_LIMIT -10000
3333

34+
#if !TEMPORARY_DISABLED_FOR_TARGETS(ESP32S2)
35+
//no runners
36+
3437
// use PCNT to test the waveform of LEDC
3538
static int16_t wave_count(int last_time)
3639
{
@@ -539,4 +542,4 @@ TEST_CASE("LEDC memory test", "[ledc][test_env=UT_T1_LEDC]")
539542
TEST_ESP_OK(ledc_stop(test_speed_mode, LEDC_CHANNEL_0, 0));
540543
}
541544

542-
545+
#endif //!TEMPORARY_DISABLED_FOR_TARGETS(ESP32S2)

components/driver/test/test_sdio.c

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
#include "param_test.h"
2020
#include "esp_log.h"
2121
#include "driver/spi_common.h"
22+
#include "soc/soc_caps.h"
2223

2324
#if defined(SOC_SDMMC_HOST_SUPPORTED) && defined(SOC_SDIO_SLAVE_SUPPORTED)
2425
#include "driver/sdio_slave.h"

components/esp_netif/test/test_esp_netif.c

+2
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ TEST_CASE("esp_netif: create and delete multiple netifs", "[esp_netif][leaks=0]"
6363

6464
}
6565

66+
#if !TEMPORARY_DISABLED_FOR_TARGETS(ESP32S2)
6667
TEST_CASE("esp_netif: test dhcp client state transitions for wifi station", "[esp_netif]")
6768
{
6869
// init default wifi netif
@@ -189,6 +190,7 @@ TEST_CASE("esp_netif: test dhcp state transitions for mesh netifs", "[esp_netif]
189190
TEST_ASSERT(esp_wifi_deinit() == ESP_OK);
190191
nvs_flash_deinit();
191192
}
193+
#endif //!TEMPORARY_DISABLED_FOR_TARGETS(ESP32S2)
192194

193195
TEST_CASE("esp_netif: create custom wifi interfaces", "[esp_netif][leaks=0]")
194196
{

components/esp_wifi/test/test_wifi.c

+3-4
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
#include "freertos/task.h"
1515
#include "freertos/event_groups.h"
1616

17-
static const char* TAG = "test_wifi";
1817

1918
#define DEFAULT_SSID "TEST_SSID"
2019
#define DEFAULT_PWD "TEST_PASS"
@@ -24,6 +23,8 @@ static const char* TAG = "test_wifi";
2423

2524
#define EVENT_HANDLER_FLAG_DO_NOT_AUTO_RECONNECT 0x00000001
2625

26+
#if !TEMPORARY_DISABLED_FOR_TARGETS(ESP32S2)
27+
static const char* TAG = "test_wifi";
2728
static uint32_t wifi_event_handler_flag;
2829

2930
static EventGroupHandle_t wifi_events;
@@ -169,8 +170,6 @@ TEST_CASE("wifi stop and deinit","[wifi]")
169170
TEST_IGNORE_MESSAGE("this test case is ignored due to the critical memory leak of esp_netif and event_loop.");
170171
}
171172

172-
#if !TEMPORARY_DISABLED_FOR_TARGETS(ESP32S2)
173-
174173
static void start_wifi_as_softap(void)
175174
{
176175
wifi_init_config_t cfg = WIFI_INIT_CONFIG_DEFAULT();
@@ -343,4 +342,4 @@ static void test_wifi_connection_softap(void)
343342

344343
TEST_CASE_MULTIPLE_DEVICES("test wifi retain connection for 60s", "[wifi][test_env=UT_T2_1][timeout=90]", test_wifi_connection_sta, test_wifi_connection_softap);
345344

346-
#endif
345+
#endif //!TEMPORARY_DISABLED_FOR_TARGETS(ESP32S2)

components/esp_wifi/test/test_wifi_init.c

+2
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
#define EVENT_HANDLER_FLAG_DO_NOT_AUTO_RECONNECT 0x00000001
1414
#define EMPH_STR(s) "****** "s" ******"
1515

16+
#if !TEMPORARY_DISABLED_FOR_TARGETS(ESP32S2)
1617
static const char* TAG = "test_wifi_init";
1718
static uint32_t wifi_event_handler_flag;
1819
static EventGroupHandle_t wifi_events;
@@ -210,3 +211,4 @@ TEST_CASE("Calling esp_wifi_stop() without start", "[wifi_init]")
210211
sema = NULL;
211212
TEST_IGNORE_MESSAGE("this test case is ignored due to the event_loop.");
212213
}
214+
#endif //!TEMPORARY_DISABLED_FOR_TARGETS(ESP32S2)

components/fatfs/test/test_fatfs_sdmmc.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -307,8 +307,8 @@ TEST_CASE("(SD) opendir, readdir, rewinddir, seekdir work as expected using UTF-
307307

308308
#endif //SDMMC HOST SUPPORTED
309309

310-
#if !TEMPORARY_DISABLED_FOR_TARGETS(ESP32S2BETA)
311-
310+
#if !TEMPORARY_DISABLED_FOR_TARGETS(ESP32S2)
311+
//no runners
312312
static void sdspi_speed_test(void *buf, size_t buf_size, size_t file_size, bool write);
313313

314314
TEST_CASE("(SDSPI) write/read speed test", "[fatfs][sd][test_env=UT_T1_SPIMODE][timeout=60]")

components/mbedtls/test/test_mbedtls_sha.c

+2
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,7 @@ void tskRunSHASelftests(void *param)
164164
vTaskDelete(NULL);
165165
}
166166

167+
#if !TEMPORARY_DISABLED_FOR_TARGETS(ESP32S2)
167168
TEST_CASE("mbedtls SHA self-tests multithreaded", "[mbedtls]")
168169
{
169170
done_sem = xSemaphoreCreateCounting(2, 0);
@@ -179,6 +180,7 @@ TEST_CASE("mbedtls SHA self-tests multithreaded", "[mbedtls]")
179180
}
180181
vSemaphoreDelete(done_sem);
181182
}
183+
#endif //!TEMPORARY_DISABLED_FOR_TARGETS(ESP32S2)
182184

183185
TEST_CASE("mbedtls SHA512 clone", "[mbedtls]")
184186
{

components/mqtt/test/test_mqtt.c

+14-12
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,6 @@ static void test_leak_setup(const char * file, long line)
1515
unity_reset_leak_checks();
1616
}
1717

18-
static const char* this_bin_addr(void)
19-
{
20-
spi_flash_mmap_handle_t out_handle;
21-
const void *binary_address;
22-
const esp_partition_t* partition = esp_ota_get_running_partition();
23-
esp_partition_mmap(partition, 0, partition->size, SPI_FLASH_MMAP_DATA, &binary_address, &out_handle);
24-
return binary_address;
25-
}
26-
2718
TEST_CASE("mqtt init with invalid url", "[mqtt][leaks=0]")
2819
{
2920
test_leak_setup(__FILE__, __LINE__);
@@ -38,22 +29,32 @@ TEST_CASE("mqtt init and deinit", "[mqtt][leaks=0]")
3829
{
3930
test_leak_setup(__FILE__, __LINE__);
4031
const esp_mqtt_client_config_t mqtt_cfg = {
41-
// no connection takes place, but the uri has to be valid for init() to succeed
32+
// no connection takes place, but the uri has to be valid for init() to succeed
4233
.uri = "mqtts://localhost:8883",
4334
};
4435
esp_mqtt_client_handle_t client = esp_mqtt_client_init(&mqtt_cfg);
4536
TEST_ASSERT_NOT_EQUAL(NULL, client );
4637
esp_mqtt_client_destroy(client);
4738
}
4839

40+
#if !TEMPORARY_DISABLED_FOR_TARGETS(ESP32S2)
41+
static const char* this_bin_addr(void)
42+
{
43+
spi_flash_mmap_handle_t out_handle;
44+
const void *binary_address;
45+
const esp_partition_t* partition = esp_ota_get_running_partition();
46+
esp_partition_mmap(partition, 0, partition->size, SPI_FLASH_MMAP_DATA, &binary_address, &out_handle);
47+
return binary_address;
48+
}
49+
4950
TEST_CASE("mqtt enqueue and destroy outbox", "[mqtt][leaks=0]")
5051
{
5152
const char * bin_addr = this_bin_addr();
5253
test_leak_setup(__FILE__, __LINE__);
5354
const int messages = 20;
5455
const int size = 2000;
5556
const esp_mqtt_client_config_t mqtt_cfg = {
56-
// no connection takes place, but the uri has to be valid for init() to succeed
57+
// no connection takes place, but the uri has to be valid for init() to succeed
5758
.uri = "mqtts://localhost:8883",
5859
};
5960
esp_mqtt_client_handle_t client = esp_mqtt_client_init(&mqtt_cfg);
@@ -67,4 +68,5 @@ TEST_CASE("mqtt enqueue and destroy outbox", "[mqtt][leaks=0]")
6768
TEST_ASSERT_GREATER_OR_EQUAL(messages*size, bytes_before - bytes_after);
6869

6970
esp_mqtt_client_destroy(client);
70-
}
71+
}
72+
#endif //!TEMPORARY_DISABLED_FOR_TARGETS(ESP32S2)

components/protocomm/test/test_protocomm.c

+6-2
Original file line numberDiff line numberDiff line change
@@ -878,7 +878,7 @@ static esp_err_t test_security1_wrong_pop (void)
878878
return ESP_OK;
879879
}
880880

881-
static esp_err_t test_security1_insecure_client (void)
881+
__attribute__((unused)) static esp_err_t test_security1_insecure_client (void)
882882
{
883883
ESP_LOGI(TAG, "Starting Security 1 insecure client test");
884884

@@ -930,7 +930,7 @@ static esp_err_t test_security1_insecure_client (void)
930930
return ESP_OK;
931931
}
932932

933-
static esp_err_t test_security1_weak_session (void)
933+
__attribute__((unused)) static esp_err_t test_security1_weak_session (void)
934934
{
935935
ESP_LOGI(TAG, "Starting Security 1 weak session test");
936936

@@ -1098,6 +1098,7 @@ static esp_err_t test_security0 (void)
10981098
return ESP_OK;
10991099
}
11001100

1101+
#if !TEMPORARY_DISABLED_FOR_TARGETS(ESP32S2)
11011102
TEST_CASE("leak test", "[PROTOCOMM]")
11021103
{
11031104
#ifdef CONFIG_HEAP_TRACING
@@ -1138,6 +1139,7 @@ TEST_CASE("leak test", "[PROTOCOMM]")
11381139

11391140
TEST_ASSERT(pre_start_mem == post_stop_mem);
11401141
}
1142+
#endif //!TEMPORARY_DISABLED_FOR_TARGETS(ESP32S2)
11411143

11421144
TEST_CASE("security 0 basic test", "[PROTOCOMM]")
11431145
{
@@ -1164,6 +1166,7 @@ TEST_CASE("security 1 wrong pop test", "[PROTOCOMM]")
11641166
TEST_ASSERT(test_security1_wrong_pop() == ESP_OK);
11651167
}
11661168

1169+
#if !TEMPORARY_DISABLED_FOR_TARGETS(ESP32S2)
11671170
TEST_CASE("security 1 insecure client test", "[PROTOCOMM]")
11681171
{
11691172
TEST_ASSERT(test_security1_insecure_client() == ESP_OK);
@@ -1173,3 +1176,4 @@ TEST_CASE("security 1 weak session test", "[PROTOCOMM]")
11731176
{
11741177
TEST_ASSERT(test_security1_weak_session() == ESP_OK);
11751178
}
1179+
#endif //!TEMPORARY_DISABLED_FOR_TARGETS(ESP32S2)

components/spi_flash/test/test_large_flash_writes.c

+2
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
#include "../cache_utils.h"
3030
#include "soc/timer_periph.h"
3131

32+
#if !TEMPORARY_DISABLED_FOR_TARGETS(ESP32S2)
3233
static const uint8_t large_const_buffer[16400] = {
3334
203, // first byte
3435
1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,
@@ -93,3 +94,4 @@ static void test_write_large_buffer(const uint8_t *source, size_t length)
9394
TEST_ASSERT_EQUAL_HEX8(0xFF, ends[2]);
9495
TEST_ASSERT_EQUAL_HEX8(0xFF, ends[3]);
9596
}
97+
#endif //!TEMPORARY_DISABLED_FOR_TARGETS(ESP32S2)

components/spi_flash/test/test_mmap.c

+2
Original file line numberDiff line numberDiff line change
@@ -349,6 +349,7 @@ TEST_CASE("flash_mmap can mmap after get enough free MMU pages", "[spi_flash][mm
349349
TEST_ASSERT_EQUAL_PTR(NULL, spi_flash_phys2cache(start, SPI_FLASH_MMAP_DATA));
350350
}
351351

352+
#if !TEMPORARY_DISABLED_FOR_TARGETS(ESP32S2)
352353
TEST_CASE("phys2cache/cache2phys basic checks", "[spi_flash][mmap]")
353354
{
354355
uint8_t buf[64];
@@ -381,6 +382,7 @@ TEST_CASE("phys2cache/cache2phys basic checks", "[spi_flash][mmap]")
381382
spi_flash_read_maybe_encrypted(phys, buf, sizeof(constant_data));
382383
TEST_ASSERT_EQUAL_HEX8_ARRAY(constant_data, buf, sizeof(constant_data));
383384
}
385+
#endif //!TEMPORARY_DISABLED_FOR_TARGETS(ESP32S2)
384386

385387
TEST_CASE("mmap consistent with phys2cache/cache2phys", "[spi_flash][mmap]")
386388
{

components/spi_flash/test/test_partitions.c

+4
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
#include <esp_partition.h>
2828
#include <esp_attr.h>
2929

30+
#if !TEMPORARY_DISABLED_FOR_TARGETS(ESP32S2)
3031
TEST_CASE("Test erase partition", "[spi_flash][esp_flash]")
3132
{
3233
const esp_partition_t *part = get_test_data_partition();
@@ -68,6 +69,7 @@ TEST_CASE("Test erase partition", "[spi_flash][esp_flash]")
6869
}
6970
}
7071
}
72+
#endif //!TEMPORARY_DISABLED_FOR_TARGETS(ESP32S2)
7173

7274
static bool s_test_nonzero_sha_of_partition(const esp_partition_t *part, bool allow_invalid_image)
7375
{
@@ -102,6 +104,7 @@ TEST_CASE("Test esp_partition_get_sha256() with data", "[spi_flash]")
102104
s_test_nonzero_sha_of_partition(part, false);
103105
}
104106

107+
#if !TEMPORARY_DISABLED_FOR_TARGETS(ESP32S2)
105108
TEST_CASE("Test esp_partition_get_sha256() with app", "[spi_flash]")
106109
{
107110
bool found_valid_app = false;
@@ -121,4 +124,5 @@ TEST_CASE("Test esp_partition_get_sha256() with app", "[spi_flash]")
121124

122125
TEST_ASSERT_MESSAGE(found_valid_app, "At least one app partition should be a valid app partition");
123126
}
127+
#endif //!TEMPORARY_DISABLED_FOR_TARGETS(ESP32S2)
124128

components/spi_flash/test/test_read_write.c

+3
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@
3030

3131
#define MIN_BLOCK_SIZE 12
3232
/* Base offset in flash for tests. */
33+
34+
#if !TEMPORARY_DISABLED_FOR_TARGETS(ESP32S2)
3335
static size_t start;
3436

3537
static void setup_tests(void)
@@ -138,6 +140,7 @@ TEST_CASE("Test spi_flash_read", "[spi_flash][esp_flash]")
138140
}
139141
#endif
140142
}
143+
#endif //!TEMPORARY_DISABLED_FOR_TARGETS(ESP32S2)
141144

142145
#if !TEMPORARY_DISABLED_FOR_TARGETS(ESP32S2)
143146
static void IRAM_ATTR test_write(int dst_off, int src_off, int len)

components/wpa_supplicant/test/test_crypto.c

+2
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
#include "mbedtls/ecp.h"
2424
typedef struct crypto_bignum crypto_bignum;
2525

26+
#if !TEMPORARY_DISABLED_FOR_TARGETS(ESP32S2)
2627
TEST_CASE("Test crypto lib bignum apis", "[wpa_crypto]")
2728
{
2829
{
@@ -278,6 +279,7 @@ TEST_CASE("Test crypto lib bignum apis", "[wpa_crypto]")
278279

279280
}
280281
}
282+
#endif //!TEMPORARY_DISABLED_FOR_TARGETS(ESP32S2)
281283

282284

283285
/*

components/wpa_supplicant/test/test_sae.c

+2
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727

2828
typedef struct crypto_bignum crypto_bignum;
2929

30+
#if !TEMPORARY_DISABLED_FOR_TARGETS(ESP32S2)
3031
static struct wpabuf *wpabuf_alloc2(size_t len)
3132
{
3233
struct wpabuf *buf = (struct wpabuf *)os_zalloc(sizeof(struct wpabuf) + len);
@@ -266,5 +267,6 @@ TEST_CASE("Test SAE functionality with ECC group", "[wpa3_sae]")
266267
ESP_LOGI("SAE Test", "=========== Complete ============");
267268

268269
}
270+
#endif //!TEMPORARY_DISABLED_FOR_TARGETS(ESP32S2)
269271

270272
#endif /* CONFIG_WPA3_SAE */

tools/ci/config/target-test.yml

+16-2
Original file line numberDiff line numberDiff line change
@@ -493,9 +493,23 @@ UT_034:
493493
- ESP32_IDF
494494
- UT_T1_ESP_FLASH
495495

496-
UT_035:
496+
.unit_test_s2_template:
497497
extends: .unit_test_template
498-
parallel: 24
498+
only:
499+
refs:
500+
# Due to lack of runners, the tests are only done by manual trigger
501+
# - master
502+
# - /^release\/v/
503+
# - /^v\d+\.\d+(\.\d+)?($|-)/
504+
- triggers
505+
# - schedules
506+
variables:
507+
- $BOT_TRIGGER_WITH_LABEL == null
508+
- $BOT_LABEL_UNIT_TEST_S2
509+
510+
UT_035:
511+
extends: .unit_test_s2_template
512+
parallel: 26
499513
tags:
500514
- ESP32S2_IDF
501515
- UT_T1_1

tools/unit-test-app/tools/UnitTestParser.py

-4
Original file line numberDiff line numberDiff line change
@@ -81,10 +81,6 @@ def parse_test_cases_for_one_config(self, configs_folder, config_output_folder,
8181
else:
8282
target = "esp32"
8383

84-
if target == "esp32s2":
85-
# Unit tests temporarily disabled for beta chip
86-
return []
87-
8884
test_groups = self.get_test_groups(os.path.join(configs_folder, config_name))
8985

9086
elf_file = os.path.join(config_output_folder, self.ELF_FILE)

0 commit comments

Comments
 (0)