fix(wifi): Fix WiFi setTxPower and getTxPower #9862

me-no-dev · 2024-06-14T06:46:41Z

We need to wait for the interface to be started in order to be able to set/get TX Power. Code was returning too early, so calling the functions after begin() resulted in failure.

Fixes: #9858

We need to wait for the interface to be started in order to be able to set/get TX Power. Code was returning too early, so calling the functions after `begin()` resulted in failure.

github-actions · 2024-06-14T06:47:15Z

	Warnings
⚠️	Some issues found for the commit messages in this PR: the commit message `"fix(wifi): Fix WiFi setTxPower and getTxPower"`: body's lines must not be longer than 100 characters Please fix these commit messages - here are some basic tips: follow Conventional Commits style correct format of commit message should be: `<type/action>(<scope/component>): <summary>`, for example `fix(esp32): Fixed startup timeout issue` allowed types are: `change,ci,docs,feat,fix,refactor,remove,revert,test` sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter avoid Jira references in commit messages (unavailable/irrelevant for our customers) `TIP:` Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello me-no-dev, we appreciate your contribution to this project!

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 0f15260

github-actions · 2024-06-14T06:49:18Z

Test Results

56 files 56 suites 5m 16s ⏱️
21 tests 21 ✅ 0 💤 0 ❌
135 runs 135 ✅ 0 💤 0 ❌

Results for commit 0f15260.

♻️ This comment has been updated with latest results.

github-actions · 2024-06-14T06:53:54Z

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

Memory	FLASH [bytes]		FLASH [%]		RAM [bytes]		RAM [%]
Target	DEC	INC	DEC	INC	DEC	INC	DEC	INC
ESP32S3	0	0	0.00	0.00	0	0	0.00	0.00
ESP32S2	0	0	0.00	0.00	0	0	0.00	0.00
ESP32C3	0	0	0.00	0.00	0	0	0.00	0.00
ESP32C6	0	0	0.00	0.00	0	0	0.00	0.00
ESP32	0	0	0.00	0.00	0	0	0.00	0.00

Click to expand the detailed deltas report [usage change in BYTES]

Target	ESP32S3		ESP32S2		ESP32C3		ESP32C6		ESP32
Example	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM
WiFi/examples/FTM/FTM_Initiator	-	-	-	-	-	-	-	-	-	-
WiFi/examples/FTM/FTM_Responder	-	-	-	-	-	-	-	-	-	-
WiFi/examples/SimpleWiFiServer	-	-	-	-	-	-	-	-	-	-
WiFi/examples/WPS	-	-	-	-	-	-	-	-	-	-
WiFi/examples/WiFiAccessPoint	-	-	-	-	-	-	-	-	-	-
WiFi/examples/WiFiBlueToothSwitch	-	-	-	-	-	-	-	-	-	-
WiFi/examples/WiFiClient	-	-	-	-	-	-	-	-	-	-
WiFi/examples/WiFiClientBasic	-	-	-	-	-	-	-	-	-	-
WiFi/examples/WiFiClientConnect	-	-	-	-	-	-	-	-	-	-
WiFi/examples/WiFiClientEnterprise	-	-	-	-	-	-	-	-	-	-
WiFi/examples/WiFiClientEvents	-	-	-	-	-	-	-	-	-	-
WiFi/examples/WiFiClientStaticIP	-	-	-	-	-	-	-	-	-	-
WiFi/examples/WiFiIPv6	-	-	-	-	-	-	-	-	-	-
WiFi/examples/WiFiMulti	-	-	-	-	-	-	-	-	-	-
WiFi/examples/WiFiMultiAdvanced	-	-	-	-	-	-	-	-	-	-
WiFi/examples/WiFiScan	-	-	-	-	-	-	-	-	-	-
WiFi/examples/WiFiScanAsync	-	-	-	-	-	-	-	-	-	-
WiFi/examples/WiFiScanDualAntenna	-	-	-	-	-	-	-	-	-	-
WiFi/examples/WiFiSmartConfig	-	-	-	-	-	-	-	-	-	-
WiFi/examples/WiFiTelnetToSerial	-	-	-	-	-	-	-	-	-	-
WiFi/examples/WiFiUDPClient	-	-	-	-	-	-	-	-	-	-

SuGlider

LGTM

zebraonpc

The real Tx Power does not changed even if WiFi.getTxPower() shows correct power my esp32-s doesnt change output power it is always the same i measured it

SuGlider · 2024-06-28T21:14:28Z

The real Tx Power does not changed even if WiFi.getTxPower() shows correct power my esp32-s doesnt change output power it is always the same i measured it

I think that it not measuring the real Power, but just returning the setTxPower() value.

zebraonpc · 2024-07-01T08:53:59Z

The real Tx Power does not changed even if WiFi.getTxPower() shows correct power my esp32-s doesnt change output power it is always the same i measured it

I think that it not measuring the real Power, but just returning the setTxPower() value.

ergo the library doesnt really work correctly with the ESP32-S

me-no-dev · 2024-07-01T08:58:22Z

All that Arduino does is call esp_wifi_set_max_tx_power(power). I suggest you as in the IDF repo and see if they have an idea why in reality power is not changed.

TD-er · 2024-07-01T09:06:32Z

The real Tx Power does not changed even if WiFi.getTxPower() shows correct power my esp32-s doesnt change output power it is always the same i measured it

What were the TX power values you tried?
Please be aware the ESP cannot change to just any TX power value as there are only some discrete steps.
Also the max. TX power differs based on the type of connection you use.
e.g. 802.11b typically allows for higher TX power compared to 802.11n. (typically 20-ish vs. 13 or 14 dBm respectively, may change per ESP model)

fix(wifi): Fix WiFi setTxPower and getTxPower

fe6e747

We need to wait for the interface to be started in order to be able to set/get TX Power. Code was returning too early, so calling the functions after `begin()` resulted in failure.

me-no-dev added the Status: Review needed Issue or PR is awaiting review label Jun 14, 2024

VojtechBartoska requested review from lucasssvaz and SuGlider June 17, 2024 12:12

lucasssvaz approved these changes Jun 17, 2024

View reviewed changes

me-no-dev added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Jun 17, 2024

ci(pre-commit): Apply automatic fixes

0f15260

SuGlider approved these changes Jun 17, 2024

View reviewed changes

me-no-dev merged commit c43187a into master Jun 17, 2024
53 checks passed

me-no-dev deleted the bugfix/wifi_tx_power branch June 17, 2024 19:47

SuGlider mentioned this pull request Jun 18, 2024

sntp problem with 3.0 #9879

Closed

1 task

zebraonpc reviewed Jun 20, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(wifi): Fix WiFi setTxPower and getTxPower #9862

fix(wifi): Fix WiFi setTxPower and getTxPower #9862

me-no-dev commented Jun 14, 2024

github-actions bot commented Jun 14, 2024 •

edited

Loading

github-actions bot commented Jun 14, 2024 •

edited

Loading

github-actions bot commented Jun 14, 2024

SuGlider left a comment

zebraonpc left a comment •

edited

Loading

SuGlider commented Jun 28, 2024

zebraonpc commented Jul 1, 2024

me-no-dev commented Jul 1, 2024

TD-er commented Jul 1, 2024

fix(wifi): Fix WiFi setTxPower and getTxPower #9862

fix(wifi): Fix WiFi setTxPower and getTxPower #9862

Conversation

me-no-dev commented Jun 14, 2024

github-actions bot commented Jun 14, 2024 • edited Loading

github-actions bot commented Jun 14, 2024 • edited Loading

Test Results

github-actions bot commented Jun 14, 2024

Memory usage test (comparing PR against master branch)

SuGlider left a comment

Choose a reason for hiding this comment

zebraonpc left a comment • edited Loading

Choose a reason for hiding this comment

SuGlider commented Jun 28, 2024

zebraonpc commented Jul 1, 2024

me-no-dev commented Jul 1, 2024

TD-er commented Jul 1, 2024

github-actions bot commented Jun 14, 2024 •

edited

Loading

github-actions bot commented Jun 14, 2024 •

edited

Loading

zebraonpc left a comment •

edited

Loading