From d2e47916dcd4668f97aa6aa362ea93abaa40baaf Mon Sep 17 00:00:00 2001 From: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com> Date: Thu, 21 Mar 2024 13:42:05 -0300 Subject: [PATCH 1/2] Add MacAddress string constructor --- cores/esp32/MacAddress.h | 1 + 1 file changed, 1 insertion(+) diff --git a/cores/esp32/MacAddress.h b/cores/esp32/MacAddress.h index 83ce362a495..5b101d6b914 100644 --- a/cores/esp32/MacAddress.h +++ b/cores/esp32/MacAddress.h @@ -54,6 +54,7 @@ class MacAddress : public Printable { MacAddress(const uint8_t *macbytearray) : MacAddress(MAC6, macbytearray) {} MacAddress(const char *macstr); + MacAddress(const String &macstr) : MacAddress(macstr.c_str()) {} virtual ~MacAddress() {} From f772c12801ca39361284f7e7b904887894a1ecb8 Mon Sep 17 00:00:00 2001 From: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com> Date: Thu, 21 Mar 2024 21:15:08 -0300 Subject: [PATCH 2/2] Change implementation --- cores/esp32/MacAddress.cpp | 4 ++++ cores/esp32/MacAddress.h | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/cores/esp32/MacAddress.cpp b/cores/esp32/MacAddress.cpp index 991fdd5e178..e1a23f5822f 100644 --- a/cores/esp32/MacAddress.cpp +++ b/cores/esp32/MacAddress.cpp @@ -28,6 +28,10 @@ MacAddress::MacAddress(const char *macstr){ fromString(macstr); } +MacAddress::MacAddress(const String &macstr){ + fromString(macstr.c_str()); +} + MacAddress::MacAddress(uint8_t b1, uint8_t b2, uint8_t b3, uint8_t b4, uint8_t b5, uint8_t b6) { _type = MAC6; memset(_mac.bytes, 0, sizeof(_mac.bytes)); diff --git a/cores/esp32/MacAddress.h b/cores/esp32/MacAddress.h index 5b101d6b914..1463bc487c5 100644 --- a/cores/esp32/MacAddress.h +++ b/cores/esp32/MacAddress.h @@ -54,7 +54,7 @@ class MacAddress : public Printable { MacAddress(const uint8_t *macbytearray) : MacAddress(MAC6, macbytearray) {} MacAddress(const char *macstr); - MacAddress(const String &macstr) : MacAddress(macstr.c_str()) {} + MacAddress(const String &macstr); virtual ~MacAddress() {}