From ee0251adcde2004acbb426e07e9d30a7994eb67e Mon Sep 17 00:00:00 2001 From: Luca Burelli Date: Wed, 10 May 2023 14:33:54 +0200 Subject: [PATCH 1/2] HardwareSerial: fix begin() lock issue on error path If the user supplied a wrong UART number, the begin() method would return without releasing the lock. Add missing unlock call. --- cores/esp32/HardwareSerial.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/cores/esp32/HardwareSerial.cpp b/cores/esp32/HardwareSerial.cpp index e60588f931e..4109f784228 100644 --- a/cores/esp32/HardwareSerial.cpp +++ b/cores/esp32/HardwareSerial.cpp @@ -367,6 +367,7 @@ void HardwareSerial::begin(unsigned long baud, uint32_t config, int8_t rxPin, in #endif default: log_e("Bad UART Number"); + HSERIAL_MUTEX_UNLOCK(); return; } } From 96cbfb89deac4c67a26c1b4d02e7129731a4f3ab Mon Sep 17 00:00:00 2001 From: Rodrigo Garcia Date: Thu, 11 May 2023 09:47:12 -0300 Subject: [PATCH 2/2] removing unsed Case test --- cores/esp32/HardwareSerial.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/cores/esp32/HardwareSerial.cpp b/cores/esp32/HardwareSerial.cpp index 4109f784228..e2b12bda3f4 100644 --- a/cores/esp32/HardwareSerial.cpp +++ b/cores/esp32/HardwareSerial.cpp @@ -365,10 +365,6 @@ void HardwareSerial::begin(unsigned long baud, uint32_t config, int8_t rxPin, in } break; #endif - default: - log_e("Bad UART Number"); - HSERIAL_MUTEX_UNLOCK(); - return; } }