DNSServer fix custom code replies #7475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree writing from buffer with sizeof(DNSHeader) in replyWithCustomCode() is a BUG. Not sure what the intent was there. Checking for null buffer in replyWithIP() is also pointless and should be removed. buffer is not referenced in that function and should never be null when called from processNextRequest(). |
true! |
VojtechBartoska
added
the
Resolution: Awaiting response
custom code reply was sending garbage from a buffer instead of crafted DNS header
vortigont
force-pushed
the
dnssrv_ccfix
branch
2 times, most recently
from
3a259bd to
0aee72a
Compare
|
@VojtechBartoska, |
VojtechBartoska
removed
the
Resolution: Awaiting response
Human
pushed a commit
to Human/arduino-esp32
that referenced
this pull request
Dec 17, 2022
custom code reply was sending garbage from a buffer instead of crafted DNS header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
custom code reply was sending garbage from a buffer instead of crafted DNS header