Skip to content

WireMaster example clarity #6844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2022
Merged

WireMaster example clarity #6844

merged 1 commit into from
Jun 24, 2022

Conversation

Luuccc
Copy link
Contributor

@Luuccc Luuccc commented Jun 8, 2022

  • Created temporary variable, removing confusion with the reuse of "error". Where Wire.requestFrom() doesn't return an error itself.
  • Added a cast to help clarify when and why bytes are being read.

@Luuccc
WireMaster example clarity
f3a7dbc 
- Created new temporary variable, stopping confusion with the reuse of "error". As Wire.requestFrom() doesn't return an error.
- Added a cast to help clarify when and why bytes are being read
@CLAassistant
Copy link

CLAassistant commented Jun 8, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@me-no-dev
Copy link
Member

Hi @Luuccc please sign the CLA, so that we can merge your changes

@VojtechBartoska VojtechBartoska added the Type: Example Issue is related to specific example. label Jun 14, 2022
@me-no-dev me-no-dev merged commit f376316 into espressif:master Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Example Issue is related to specific example.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Luuccc @CLAassistant @me-no-dev @VojtechBartoska