From 4cca60fd7a4170b4aa84c27e50487312c71db2fe Mon Sep 17 00:00:00 2001 From: Michael Ammann Date: Fri, 27 May 2022 16:41:56 +0200 Subject: [PATCH] CTS / RTS pins were swapped in this API espressif/esp-idf / components/driver/include/driver/uart.h defines the API: esp_err_t uart_set_pin(uart_port_t uart_num, int tx_io_num, int rx_io_num, int **rts_io_num**, int **cts_io_num**); uartSetPins uses that api but alls it with swapped CTS/RTS pins as its API uses a different pin ordering: uart_set_pin(uart->num, txPin, rxPin, **ctsPin**, **rtsPin**); This fixes the wrong order in the function uartSetPins --- cores/esp32/esp32-hal-uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cores/esp32/esp32-hal-uart.c b/cores/esp32/esp32-hal-uart.c index a2f6ea4c918..09a68b83d48 100644 --- a/cores/esp32/esp32-hal-uart.c +++ b/cores/esp32/esp32-hal-uart.c @@ -115,7 +115,7 @@ void uartSetPins(uart_t* uart, int8_t rxPin, int8_t txPin, int8_t ctsPin, int8_t } UART_MUTEX_LOCK(); // IDF uart_set_pin() will issue necessary Error Message and take care of all GPIO Number validation. - uart_set_pin(uart->num, txPin, rxPin, ctsPin, rtsPin); + uart_set_pin(uart->num, txPin, rxPin, rtsPin, ctsPin); UART_MUTEX_UNLOCK(); }