Skip to content

ADC fixes and improvements #6799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2022
Merged

ADC fixes and improvements #6799

merged 1 commit into from
May 27, 2022

Conversation

P-R-O-C-H-Y
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y commented May 25, 2022 •
edited
Loading

Description of Change

  • Fixed channel / unit selection for ESP32C3 (has only 5 channels on 1 adc unit).
  • Removed unnecessary includes.
  • Fixed different attenuation on channels to be taken in care in __analogReadMilliVolt.
  • All chips in __analogReadMilliVolts now use adc characteristics + calculation from raw to voltage as ESP32 does.

Tests scenarios

Tested on all chips.

Related links

Closes #6755

@P-R-O-C-H-Y
adc fixes and improvements
398695b 
Fixed channel / unit selection for ESP32C3 (has only 5 channels on 1 adc unit).

Removed unnecessary includes.

Fixed different attenuation on channels to be taken in care in __analogReadMilliVolt.

All chips in __analogReadMilliVolts now use adc characteristics + calculation from raw to voltage as ESP32 does.
@P-R-O-C-H-Y P-R-O-C-H-Y added the Area: Peripherals API Relates to peripheral's APIs. label May 25, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y added this to the 2.0.4 milestone May 25, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this May 25, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y requested a review from me-no-dev May 25, 2022 12:09
@me-no-dev me-no-dev merged commit 2cb664e into espressif:master May 27, 2022
@newHeiko
Copy link

newHeiko commented Oct 9, 2022

JFTR: This (probably) also fixes #4941

Heiko

newHeiko added a commit to newHeiko/wiFred that referenced this pull request Oct 11, 2022
@newHeiko
Detect too low battery voltage after core change
0ab0a34 
espressif/arduino-esp32#6799

Fixes #41.
@elratt0r elratt0r mentioned this pull request Nov 27, 2022
Closed
@P-R-O-C-H-Y P-R-O-C-H-Y deleted the ADC_readmilivolts_update branch April 19, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@me-no-dev me-no-dev Awaiting requested review from me-no-dev

Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
Area: Peripherals API Relates to peripheral's APIs.
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
2.0.4
Development

Successfully merging this pull request may close these issues.

ESP32C3 lib of ad-read error
3 participants
@P-R-O-C-H-Y @newHeiko @me-no-dev