Fix String.replace() broken by #6190 #6224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jason2866
added a commit
to tasmota/platform-espressif32
that referenced
this pull request
Feb 2, 2022
Jason2866
added a commit
to tasmota/platform-espressif32
that referenced
this pull request
Feb 2, 2022
|
@me-no-dev ping |
|
Thanks @s-hadinger |
|
@s-hadinger Wow that's embarrassing. Thanks for the fix. |
|
Thanks for the great work at Arduino core. Tasmota is a heavy user |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug introduced by #6190
There was no braces after
ifso thereturnstatement is taken every time, not just in case of failure.Impact
String.replace is not doing an actual replacement most of the time.
Related links