-
Notifications
You must be signed in to change notification settings - Fork 7.6k
fix(esp32c5): Add proper RTC clock source to uartSetClockSource #11255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hello Jason2866, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 76 files 76 suites 12m 45s ⏱️ Results for commit 6a54dbb. ♻️ This comment has been updated with latest results. |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It seems that this is the proper clock source. Wokwi issue is unrelated and has already been reported.
@Jason2866 - Yes, this is the proper fix for the ESP32-C5 LP UART clock source. Currently, only C5, C6 and P4 have LP UART. |
C5 fails to compile when trying to build a firmware. Can't test if the fix is correct since not having a C5. If correct fix for #11254
@SuGlider