Skip to content

feat(wifi): Add support for 2.4GHz and 5GHz band switching #11045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 10, 2025
Merged

feat(wifi): Add support for 2.4GHz and 5GHz band switching #11045

merged 2 commits into from
Mar 10, 2025

Conversation

me-no-dev
Copy link
Member

This pull request includes changes to the WiFi library to add support for scanning WiFi networks in both 2.4GHz and 5GHz bands. The most important changes include updating the example sketch to demonstrate scanning for both bands, adding new methods to control WiFi band modes, and ensuring compatibility with chips that support 5GHz WiFi.

Enhancements to WiFi scanning:

New methods for WiFi band control:

  • libraries/WiFi/src/WiFiGeneric.cpp: Added methods setBandMode, getBandMode, and getBand to control and retrieve the current WiFi band mode and active band. These methods ensure compatibility with chips supporting 5GHz WiFi.
  • libraries/WiFi/src/WiFiGeneric.h: Declared the new methods setBandMode, getBandMode, and getBand in the WiFiGenericClass.

Initialization improvements:

@me-no-dev me-no-dev added Status: Review needed Issue or PR is awaiting review Area: WiFi Issue related to WiFi labels Mar 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025 •
edited
Loading

Warnings
⚠️ 
	The **target branch** for this Pull Request **must be the default branch** of the project (`master`).

	If you would like to add this feature to a different branch, please state this in the PR description and we will consider it.

👋 Hello me-no-dev, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against c5db444

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025 •
edited
Loading

Test Results

 76 files   76 suites   13m 55s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit c5db444.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C5000.000.00000.000.00
ESP32P40‼️ +8K0.00‼️ +1.280⚠️ +480.00⚠️ +0.18
ESP32S30‼️ +2K0.00⚠️ +0.28💚 -184⚠️ +60💚 -0.40⚠️ +0.13
ESP32S20‼️ +2K0.00⚠️ +0.28💚 -2240💚 -0.550.00
ESP32C30‼️ +3K0.00⚠️ +0.28💚 -3800💚 -1.020.00
ESP32C60‼️ +10K0.00⚠️ +0.85💚 -3000💚 -0.690.00
ESP320⚠️ +16970.00⚠️ +0.19💚 -440💚 -0.090.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C5ESP32P4ESP32S3ESP32S2ESP32C3ESP32C6ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
WiFi/examples/FTM/FTM_Initiator--‼️ +8K⚠️ +48‼️ +2K⚠️ +4⚠️ +2005💚 -112‼️ +2K💚 -140‼️ +4K💚 -76⚠️ +1541💚 -28
WiFi/examples/FTM/FTM_Responder--‼️ +8K⚠️ +48‼️ +2K⚠️ +4⚠️ +2033💚 -112‼️ +2K💚 -132‼️ +4K💚 -68⚠️ +1549💚 -28
WiFi/examples/SimpleWiFiServer--‼️ +8K⚠️ +32‼️ +2K💚 -184‼️ +2K💚 -224‼️ +3K💚 -380‼️ +5K💚 -300⚠️ +1557💚 -12
WiFi/examples/WPS----‼️ +2K⚠️ +4⚠️ +2045💚 -96‼️ +2K💚 -124‼️ +4K💚 -52⚠️ +1561💚 -28
WiFi/examples/WiFiAccessPoint--‼️ +8K⚠️ +32‼️ +2K💚 -184‼️ +2K💚 -224‼️ +3K💚 -380‼️ +5K💚 -300⚠️ +1549💚 -12
WiFi/examples/WiFiBlueToothSwitch----‼️ +2K⚠️ +60--‼️ +3K💚 -124‼️ +10K💚 -60⚠️ +1697💚 -44
WiFi/examples/WiFiClient--‼️ +8K⚠️ +48‼️ +2K💚 -12⚠️ +2009💚 -96‼️ +2K💚 -140‼️ +4K💚 -76⚠️ +1557💚 -44
WiFi/examples/WiFiClientBasic--‼️ +8K⚠️ +32‼️ +2K⚠️ +4⚠️ +2009💚 -112‼️ +2K💚 -132‼️ +4K💚 -68⚠️ +1561💚 -28
WiFi/examples/WiFiClientConnect--‼️ +8K⚠️ +48‼️ +2K⚠️ +52‼️ +2K💚 -64‼️ +2K💚 -140‼️ +5K💚 -76⚠️ +1573💚 -12
WiFi/examples/WiFiClientEnterprise----‼️ +2K⚠️ +4‼️ +2K💚 -88‼️ +2K💚 -132‼️ +5K💚 -60⚠️ +1569💚 -4
WiFi/examples/WiFiClientEvents--‼️ +8K⚠️ +48‼️ +2K⚠️ +4⚠️ +2021💚 -112‼️ +2K💚 -132‼️ +4K💚 -68⚠️ +1573💚 -28
WiFi/examples/WiFiClientStaticIP--‼️ +8K⚠️ +32‼️ +2K⚠️ +4⚠️ +1993💚 -96‼️ +2K💚 -132‼️ +4K💚 -68⚠️ +1565💚 -28
WiFi/examples/WiFiExtender--‼️ +8K⚠️ +48‼️ +2K⚠️ +4⚠️ +2041💚 -88‼️ +2K💚 -132‼️ +4K💚 -68⚠️ +1557💚 -20
WiFi/examples/WiFiIPv6--‼️ +8K⚠️ +48‼️ +2K⚠️ +4⚠️ +2009💚 -96‼️ +2K💚 -132‼️ +4K💚 -68⚠️ +1561💚 -28
WiFi/examples/WiFiMulti--‼️ +8K⚠️ +32‼️ +2K⚠️ +4⚠️ +2041💚 -112‼️ +2K💚 -132‼️ +4K💚 -68⚠️ +1561💚 -28
WiFi/examples/WiFiMultiAdvanced--‼️ +8K⚠️ +32‼️ +2K⚠️ +4⚠️ +2045💚 -112‼️ +2K💚 -148‼️ +5K💚 -60⚠️ +1585💚 -12
WiFi/examples/WiFiScan--‼️ +8K⚠️ +48‼️ +2K⚠️ +4‼️ +2K💚 -112‼️ +2K💚 -132‼️ +5K💚 -68⚠️ +1685💚 -28
WiFi/examples/WiFiScanAsync--‼️ +8K⚠️ +48‼️ +2K⚠️ +4⚠️ +2017💚 -112‼️ +2K💚 -132‼️ +4K💚 -68⚠️ +1561💚 -28
WiFi/examples/WiFiScanDualAntenna--‼️ +8K⚠️ +48‼️ +2K⚠️ +36‼️ +2K💚 -64‼️ +2K💚 -140‼️ +5K💚 -76⚠️ +1585💚 -28
WiFi/examples/WiFiScanTime--‼️ +8K⚠️ +48‼️ +2K⚠️ +4⚠️ +2017💚 -112‼️ +2K💚 -132‼️ +4K💚 -68⚠️ +1557💚 -28
WiFi/examples/WiFiSmartConfig----‼️ +2K⚠️ +4⚠️ +2033💚 -96‼️ +2K💚 -132‼️ +4K💚 -68⚠️ +1549💚 -12
WiFi/examples/WiFiTelnetToSerial--‼️ +8K⚠️ +32‼️ +2K⚠️ +4‼️ +2K💚 -96‼️ +2K💚 -132‼️ +4K💚 -68⚠️ +1537💚 -28
WiFi/examples/WiFiUDPClient--‼️ +8K⚠️ +32‼️ +2K⚠️ +4⚠️ +2005💚 -112‼️ +2K💚 -140‼️ +4K💚 -76⚠️ +1545💚 -28

P-R-O-C-H-Y
P-R-O-C-H-Y approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SuGlider
SuGlider approved these changes Mar 10, 2025
View reviewed changes
Copy link
Collaborator

@SuGlider SuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuGlider SuGlider added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Mar 10, 2025
@SuGlider SuGlider moved this from Todo to In Review in Arduino ESP32 Core Project Roadmap Mar 10, 2025
@SuGlider SuGlider added this to the 3.3.0 milestone Mar 10, 2025
@me-no-dev me-no-dev merged commit 60bbe79 into release/v3.3.x Mar 10, 2025
56 checks passed
@me-no-dev me-no-dev deleted the feature/5ghz_band_modes branch March 10, 2025 20:19
me-no-dev added a commit that referenced this pull request Mar 20, 2025
@me-no-dev @pre-commit-ci-lite
feat(wifi): Add support for 2.4GHz and 5GHz band switching (#11045)
7c1ac1a 
* feat(wifi): Add support for 2.4GHz and 5GHz band switching

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuGlider SuGlider SuGlider approved these changes

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees
No one assigned
Labels
Area: WiFi Issue related to WiFi Status: Pending Merge Pull Request is ready to be merged
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@me-no-dev @SuGlider @P-R-O-C-H-Y