Skip to content

SDWebServer example has issues with paths #6488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
menachers opened this issue Mar 27, 2022 · 3 comments · Fixed by #6505
Closed
1 task done

SDWebServer example has issues with paths #6488

menachers opened this issue Mar 27, 2022 · 3 comments · Fixed by #6505
Assignees
@P-R-O-C-H-Y
Labels
Area: Libraries Issue is related to Library support.
Milestone
2.0.3

Comments

@menachers
Copy link

Board

DOIT ESP32 DEVKIT v1

Device Description

Plain module with SD reader

Hardware Configuration

Nothing special besides SD reader.

Version

v2.0.2

IDE Name

Arduino IDE

Operating System

Windows 10

Flash frequency

80 MHz

PSRAM enabled

no

Upload speed

115200

Description

When using the basic example for SDWebServer on edit mode the path are generated wrong.
A relative path is generated with a double slash // at the beginning resulting that no files can be uploaded or downloaded.
If the path in the request is manually corrected in the browser everything works fine.
So I think the problem is located in the htm file provided here:
https://github.com/espressif/arduino-esp32/tree/master/libraries/WebServer/examples/SDWebServer/SdRoot/edit

This is happening:
Screenshot 2022-03-27 154213

I tried to modify the javascript but I have no clue where to start since I have no idea where the path variable "comes from".

Sketch

-

Debug Message

-

Other Steps to Reproduce

No response

I have checked existing issues, online documentation and the Troubleshooting Guide

  • I confirm I have checked existing issues, online documentation and Troubleshooting guide.
@menachers menachers added the Status: Awaiting triage Issue is waiting for triage label Mar 27, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Mar 29, 2022
@VojtechBartoska VojtechBartoska added Area: Libraries Issue is related to Library support. and removed Status: Awaiting triage Issue is waiting for triage labels Mar 29, 2022
@P-R-O-C-H-Y
Copy link
Member

Hi @menachers,
I have tested the issue and I made a change in the example to make it work.
I will post a PR where you can see the changes later today.

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: In Progress ⚠️ Issue is in progress label Mar 31, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y mentioned this issue Mar 31, 2022
Merged
@P-R-O-C-H-Y P-R-O-C-H-Y removed the Status: In Progress ⚠️ Issue is in progress label Mar 31, 2022
@VojtechBartoska VojtechBartoska added this to the 2.0.3 milestone Mar 31, 2022
@P-R-O-C-H-Y
Copy link
Member

@menachers You can test the changes from PR #6505 till it gets merged. But don't update to 2.0.3-RC1 yet otherwise the SDWebServer won't work. SD reading needs to be fixed. Wait for 2.0.3 release.

Repository owner moved this from In Progress to Done in Arduino ESP32 Core Project Roadmap Mar 31, 2022
@menachers
Copy link
Author

Thank you for the quick fix. It works fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
Area: Libraries Issue is related to Library support.
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
2.0.3
Development

Successfully merging a pull request may close this issue.

SDWebServer example fix for 2.x.x versions P-R-O-C-H-Y/arduino-esp32
3 participants
@menachers @VojtechBartoska @P-R-O-C-H-Y