Arduino lib builder fails with CONFIG_DISABLE_HAL_LOCKS=y

[Jason2866]

Board

Esp32 board

Device Description

Fails at compile time

Hardware Configuration

none

Version

latest master

IDE Name

Arduino Lib Builder

Operating System

Ubuntu

Flash frequency

not relevant

PSRAM enabled

no

Upload speed

none

Description

Arduino Lib Builder fails when Option CONFIG_DISABLE_HAL_LOCKS=y is set

builder/components/arduino/cores/esp32/esp32-hal-i2c-slave.c
/home/runner/work/esp32-arduino-lib-builder/esp32-arduino-lib-builder/components/arduino/cores/esp32/esp32-hal-i2c-slave.c: In function 'i2cSlaveDeinit':
/home/runner/work/esp32-arduino-lib-builder/esp32-arduino-lib-builder/components/arduino/cores/esp32/esp32-hal-i2c-slave.c:363:12: error: 'i2c_slave_struct_t' {aka 'struct i2c_slave_struct_t'} has no member named 'lock'
     if(!i2c->lock){
            ^~
/home/runner/work/esp32-arduino-lib-builder/esp32-arduino-lib-builder/components/arduino/cores/esp32/esp32-hal-i2c-slave.c: In function

Sketch

https://github.com/Jason2866/esp32-arduino-lib-builder

Debug Message

Not relevant

Other Steps to Reproduce

No response

I have checked existing issues, online documentation and the Troubleshooting Guide

• I confirm I have checked existing issues, online documentation and Troubleshooting guide.

[atanisoft]

Duplicate of #5943.

Remove CONFIG_DISABLE_HAL_LOCKS=y in your sdkconfig file and it will work as expected.

@me-no-dev Can you fix

arduino-esp32/cores/esp32/esp32-hal-i2c-slave.c

Lines 363 to 366 in caef400

	if(!i2c->lock){
	log_e("Lock is not initialized! Did you call i2c_slave_init()?");
	return ESP_ERR_NO_MEM;
	}

to be wrapped in a check for locks being configured?

[Jason2866]

@atanisoft I know. Why is the option there, when I cannot use? I want to disable HAL locks. To be clear it will fail in Arduino code when you set the option.
It IS a bug! imho just one solution, remove or fix

[atanisoft]

Why is the option there, when I cannot use?

The option is there as there are some use cases for not having locks used, but it does introduce a number of potential issues at runtime when using a multi-core ESP32. I agree it is a bug that it is failing to compile currently and was acknowledged as such in the referenced issue (which shouldn't have been closed without the fix being merged).

[Jason2866]

I know what it does and what can happen. Using with a single core ESP32 (solo1)
with a custom compiled Arduino framework.
https://github.com/Jason2866/esp32-arduino-lib-builder/releases/tag/556

[Jason2866]

probably solved with #6108

[VojtechBartoska]

Closing as solved. Thanks for contribution.