Skip to content

HTTPClient redirection with different host does not replace the host #4646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thegreatdane6 opened this issue Dec 19, 2020 · 4 comments
Closed

Comments

@thegreatdane6
Copy link

thegreatdane6 commented Dec 19, 2020

After enabling the HTTPClient redirection, i kept running into a 404 Status Code. So I did some investigation and noticed that the host does not get changed if the host in the location header is different than the previous one.
I assume the issue must be somewhere within the "beginInternal" since i cannot see any changes related to this in #4240.
For everyone that cannot wait for a fix, I implemented a workaround for myself which you can check out here

"https://github.com/MaibornWolff/clean-air/releases/download/LATEST"
with response location
"Location: https://github.com/MaibornWolff/clean-air/releases/download/v1.1.0/LATEST"
leads to requesting
"https://github.com/MaibornWolff/clean-air/releases/download/v1.1.0/LATEST"

but
"https://github.com/MaibornWolff/clean-air/releases/download/v1.1.0/LATEST"
with response location
"Location: https://github-production-release-asset-2e65be.s3.amazonaws.com/more/stuff?&soon"
leads to requesting
"https://github.com/more/stuff?&soon"

@stale
Copy link

stale bot commented Feb 18, 2021

[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Stale Issue is stale stage (outdated/stuck) label Feb 18, 2021
@Batwam
Copy link

Batwam commented Feb 22, 2021

@thegreatdane6 did you find a solution to this issue?

@stale
Copy link

stale bot commented Feb 22, 2021

[STALE_CLR] This issue has been removed from the stale queue. Please ensure activity to keep it openin the future.

@stale stale bot removed the Status: Stale Issue is stale stage (outdated/stuck) label Feb 22, 2021
@me-no-dev
Copy link
Member

it is fixed in the latest RC/master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants