BLEScan crashing when running for long time

[roy-zahor]

Hardware:

Board: ESP-WROOM-32D
Core Installation version: ?
IDE name: Platform.io
Flash Frequency: 40Mhz
Upload Speed: 115200
Computer OS: Windows 10

Description:

When running a BLE scan for a long time (timeout=0), or in an environment full of BLE transmitters, memory gets full and eventually leading to a system crash.

Sketch:

    BLEDevice::init("");
    pBLEScan = BLEDevice::getScan(); //create new scan
    pBLEScan->setAdvertisedDeviceCallbacks(new MyAdvertisedDeviceCallbacks());
    pBLEScan->setActiveScan(true); //active scan uses more power, but get results faster

    BLEScanResults foundDevices = pBLEScan->start(0);

In BLEScan.c, the following line (106):
BLEAdvertisedDevice *advertisedDevice = new BLEAdvertisedDevice();
is not safe, because there is no check that new() operator returned a valid address, leading to system crash in case of low memory.

[stale]

[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

[stale]

[STALE_DEL] This stale issue has been automatically closed. Thank you for your contributions.

[Ben79543]

I would like this issue to be reopened:

I have a device doing BLE Scans and it works fine in general.
Yesterday I tried it in a fair where there were at least 200 beacons around me.
My scan time is 5 sec.
The device crashes and I suppose it is because of memory issue too.

@roy-zahor did you work around this on your side?

[roy-zahor]

@Ben79543 Solved for me by calling clearResults() once in a while. I'm not sure you have the same problem.