Skip to content

Commit fd1a84d

Browse files
committed
fix(zigbee): Add a 10s timeout for temp sensor settings read
1 parent 712e523 commit fd1a84d

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

Diff for: libraries/Zigbee/src/ZigbeeEP.cpp

-2
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77
#include "esp_zigbee_cluster.h"
88
#include "zcl/esp_zigbee_zcl_power_config.h"
99

10-
#define ZB_CMD_TIMEOUT 10000 // 10 seconds
11-
1210
bool ZigbeeEP::_is_bound = false;
1311
bool ZigbeeEP::_allow_multiple_binding = false;
1412

Diff for: libraries/Zigbee/src/ZigbeeEP.h

+2
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@
88
#include <Arduino.h>
99

1010
/* Useful defines */
11+
#define ZB_CMD_TIMEOUT 10000 // 10 seconds
12+
1113
#define ZB_ARRAY_LENTH(arr) (sizeof(arr) / sizeof(arr[0]))
1214
#define XYZ_TO_RGB(X, Y, Z, r, g, b) \
1315
{ \

Diff for: libraries/Zigbee/src/ep/ZigbeeThermostat.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ void ZigbeeThermostat::getSensorSettings() {
166166
esp_zb_lock_release();
167167

168168
//Take semaphore to wait for response of all attributes
169-
if (xSemaphoreTake(lock, portMAX_DELAY) != pdTRUE) {
169+
if (xSemaphoreTake(lock, ZB_CMD_TIMEOUT) != pdTRUE) {
170170
log_e("Error while reading attributes");
171171
return;
172172
} else {

0 commit comments

Comments
 (0)