Skip to content

Commit fb6630f

Browse files
committed
64bit integers instead of 32bits, timer functions on ESP32 accept 64bit integers.
1 parent d63f0b1 commit fb6630f

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

Diff for: libraries/Ticker/src/Ticker.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,12 @@ void Ticker::_attach_s(float seconds, bool repeat, callback_with_arg_t callback,
3939
_attach_us(1000000ULL * seconds, repeat, callback, arg);
4040
}
4141

42-
void Ticker::_attach_ms(uint32_t milliseconds, bool repeat, callback_with_arg_t callback, void* arg)
42+
void Ticker::_attach_ms(uint64_t milliseconds, bool repeat, callback_with_arg_t callback, void* arg)
4343
{
4444
_attach_us(1000ULL * milliseconds, repeat, callback, arg);
4545
}
4646

47-
void Ticker::_attach_us(uint32_t micros, bool repeat, callback_with_arg_t callback, void* arg)
47+
void Ticker::_attach_us(uint64_t micros, bool repeat, callback_with_arg_t callback, void* arg)
4848
{
4949
esp_timer_create_args_t _timerConfig;
5050
_timerConfig.arg = reinterpret_cast<void*>(arg);

Diff for: libraries/Ticker/src/Ticker.h

+10-10
Original file line numberDiff line numberDiff line change
@@ -45,13 +45,13 @@ class Ticker
4545
_attach_s(seconds, true, _static_callback, this);
4646
}
4747

48-
void attach_ms(uint32_t milliseconds, callback_function_t callback)
48+
void attach_ms(uint64_t milliseconds, callback_function_t callback)
4949
{
5050
_callback_function = std::move(callback);
5151
_attach_ms(milliseconds, true, _static_callback, this);
5252
}
5353

54-
void attach_us(uint32_t micros, callback_function_t callback)
54+
void attach_us(uint64_t micros, callback_function_t callback)
5555
{
5656
_callback_function = std::move(callback);
5757
_attach_us(micros, true, _static_callback, this);
@@ -68,14 +68,14 @@ class Ticker
6868
}
6969

7070
template<typename TArg>
71-
void attach_ms(uint32_t milliseconds, void (*callback)(TArg), TArg arg)
71+
void attach_ms(uint64_t milliseconds, void (*callback)(TArg), TArg arg)
7272
{
7373
static_assert(sizeof(TArg) <= sizeof(void*), "attach() callback argument size must be <= sizeof(void*)");
7474
_attach_ms(milliseconds, true, reinterpret_cast<callback_with_arg_t>(callback), (void*)arg);
7575
}
7676

7777
template<typename TArg>
78-
void attach_us(uint32_t micros, void (*callback)(TArg), TArg arg)
78+
void attach_us(uint64_t micros, void (*callback)(TArg), TArg arg)
7979
{
8080
static_assert(sizeof(TArg) <= sizeof(void*), "attach() callback argument size must be <= sizeof(void*)");
8181
_attach_us(micros, true, reinterpret_cast<callback_with_arg_t>(callback), (void*)arg);
@@ -87,13 +87,13 @@ class Ticker
8787
_attach_s(seconds, false, _static_callback, this);
8888
}
8989

90-
void once_ms(uint32_t milliseconds, callback_function_t callback)
90+
void once_ms(uint64_t milliseconds, callback_function_t callback)
9191
{
9292
_callback_function = std::move(callback);
9393
_attach_ms(milliseconds, false, _static_callback, this);
9494
}
9595

96-
void once_us(uint32_t micros, callback_function_t callback)
96+
void once_us(uint64_t micros, callback_function_t callback)
9797
{
9898
_callback_function = std::move(callback);
9999
_attach_us(micros, false, _static_callback, this);
@@ -107,14 +107,14 @@ class Ticker
107107
}
108108

109109
template<typename TArg>
110-
void once_ms(uint32_t milliseconds, void (*callback)(TArg), TArg arg)
110+
void once_ms(uint64_t milliseconds, void (*callback)(TArg), TArg arg)
111111
{
112112
static_assert(sizeof(TArg) <= sizeof(void*), "attach() callback argument size must be <= sizeof(void*)");
113113
_attach_ms(milliseconds, false, reinterpret_cast<callback_with_arg_t>(callback), (void*)arg);
114114
}
115115

116116
template<typename TArg>
117-
void once_us(uint32_t micros, void (*callback)(TArg), TArg arg)
117+
void once_us(uint64_t micros, void (*callback)(TArg), TArg arg)
118118
{
119119
static_assert(sizeof(TArg) <= sizeof(void*), "attach() callback argument size must be <= sizeof(void*)");
120120
_attach_us(micros, false, reinterpret_cast<callback_with_arg_t>(callback), (void*)arg);
@@ -124,15 +124,15 @@ class Ticker
124124
bool active() const;
125125

126126
protected:
127-
void _attach_ms(uint32_t milliseconds, bool repeat, callback_with_arg_t callback, void* arg);
127+
void _attach_ms(uint64_t milliseconds, bool repeat, callback_with_arg_t callback, void* arg);
128128
static void _static_callback(void* arg);
129129

130130
callback_function_t _callback_function = nullptr;
131131

132132
esp_timer_handle_t _timer;
133133

134134
private:
135-
void _attach_us(uint32_t micros, bool repeat, callback_with_arg_t callback, void* arg);
135+
void _attach_us(uint64_t micros, bool repeat, callback_with_arg_t callback, void* arg);
136136
void _attach_s(float seconds, bool repeat, callback_with_arg_t callback, void* arg);
137137
};
138138

0 commit comments

Comments
 (0)