Skip to content

Commit deaf339

Browse files
bperrybapme-no-dev
authored andcommitted
Wire endTransmission() fix for issue #1725 (#1888)
* removed uint8_t Wire.endTransmission(uint8_t sendStop) Having both endTransmission(bool) and endTransmission(uint8_t) creates problems. There is no need for endTransmission(uint8_t) endTransmission(1) and endTransmission(0) works with endTransmission(bool). Removing endTransmission(uint8_t) allows the ESP32 code to be compatible with all the other Arduino cores by allowing endTransmission(1) and endTranmission(0) to work as it does on all the other cores. * Wire library version bump for endTransmission() update
1 parent f12df4c commit deaf339

File tree

3 files changed

+1
-7
lines changed

3 files changed

+1
-7
lines changed

Diff for: libraries/Wire/library.properties

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name=Wire
2-
version=1.0
2+
version=1.0.1
33
author=Hristo Gochkov
44
maintainer=Hristo Gochkov <[email protected]>
55
sentence=Allows the communication between devices or sensors connected via Two Wire Interface Bus. For esp8266 boards.

Diff for: libraries/Wire/src/Wire.cpp

-5
Original file line numberDiff line numberDiff line change
@@ -308,11 +308,6 @@ uint8_t TwoWire::endTransmission(void)
308308
return endTransmission(true);
309309
}
310310

311-
uint8_t TwoWire::endTransmission(uint8_t sendStop)
312-
{
313-
return endTransmission(static_cast<bool>(sendStop));
314-
}
315-
316311
/* stickbreaker Nov2017 better error reporting
317312
*/
318313
uint8_t TwoWire::lastError()

Diff for: libraries/Wire/src/Wire.h

-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@ class TwoWire: public Stream
8787
void beginTransmission(int address);
8888

8989
uint8_t endTransmission(bool sendStop);
90-
uint8_t endTransmission(uint8_t sendStop);
9190
uint8_t endTransmission(void);
9291

9392
uint8_t requestFrom(uint16_t address, uint8_t size, bool sendStop);

0 commit comments

Comments
 (0)