Skip to content

Commit d3f51ee

Browse files
authored
fix(uart): ci error with change pins test on ESP32
1 parent f2bc23d commit d3f51ee

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

tests/validation/uart/uart.ino

+9-7
Original file line numberDiff line numberDiff line change
@@ -365,26 +365,28 @@ void change_pins_test(void) {
365365

366366
if (TEST_UART_NUM == 1) {
367367
UARTTestConfig &config = *uart_test_configs[0];
368-
// internal loopback causes UART BREAK on ESP32 and ESP32-S2
368+
// internal loopback creates a BREAK on ESP32 and ESP32-S2
369369
// setting it before changing the pins solves it
370-
uart_internal_loopback(config.uart_num, NEW_RX1);
370+
uart_internal_loopback(config.uart_num, NEW_RX1);
371371
config.serial.setPins(NEW_RX1, NEW_TX1);
372372
TEST_ASSERT_EQUAL(NEW_RX1, uart_get_RxPin(config.uart_num));
373373
TEST_ASSERT_EQUAL(NEW_TX1, uart_get_TxPin(config.uart_num));
374-
config.transmit_and_check_msg("using new uart#1 pins");
374+
config.transmit_and_check_msg("using new UART#1 pins");
375375
} else {
376376
for (int i = 0; i < TEST_UART_NUM; i++) {
377377
UARTTestConfig &config = *uart_test_configs[i];
378378
UARTTestConfig &next_uart = *uart_test_configs[(i + 1) % TEST_UART_NUM];
379+
// internal loopback creates a BREAK on ESP32 and ESP32-S2
380+
// setting it before changing the pins solves it
381+
uart_internal_loopback(config.uart_num, next_uart.default_rx_pin);
379382
config.serial.setPins(next_uart.default_rx_pin, next_uart.default_tx_pin);
380383
TEST_ASSERT_EQUAL(uart_get_RxPin(config.uart_num), next_uart.default_rx_pin);
381384
TEST_ASSERT_EQUAL(uart_get_TxPin(config.uart_num), next_uart.default_tx_pin);
382-
383-
uart_internal_loopback(config.uart_num, next_uart.default_rx_pin);
384-
config.transmit_and_check_msg("using new pins");
385+
String msg = String("using UART#") + config.uart_num + " pins";
386+
config.transmit_and_check_msg(msg.c_str());
385387
}
386388
}
387-
389+
388390
Serial.println("Change pins test successful");
389391
}
390392

0 commit comments

Comments
 (0)