fix(uart): fixes pins detaching - shall revert loopback

SuGlider · web-flow · commit c35b76e9f6dd · 2024-10-24T11:39:41.000-03:00
diff --git a/cores/esp32/esp32-hal-uart.c b/cores/esp32/esp32-hal-uart.c
@@ -166,13 +166,15 @@ static bool _uartDetachBus_RX(void *busptr) {
   // sanity check - it should never happen
   assert(busptr && "_uartDetachBus_RX bus NULL pointer.");
   uart_t *bus = (uart_t *)busptr;
+  uart_set_loop_back(bus->num, false); // disable loopback
   return _uartDetachPins(bus->num, bus->_rxPin, UART_PIN_NO_CHANGE, UART_PIN_NO_CHANGE, UART_PIN_NO_CHANGE);
 }
 
 static bool _uartDetachBus_TX(void *busptr) {
   // sanity check - it should never happen
   assert(busptr && "_uartDetachBus_TX bus NULL pointer.");
   uart_t *bus = (uart_t *)busptr;
+  uart_set_loop_back(bus->num, false); // disable loopback
   return _uartDetachPins(bus->num, UART_PIN_NO_CHANGE, bus->_txPin, UART_PIN_NO_CHANGE, UART_PIN_NO_CHANGE);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -166,13 +166,15 @@ static bool _uartDetachBus_RX(void *busptr) {`
`166`	`166`	`// sanity check - it should never happen`
`167`	`167`	`assert(busptr && "_uartDetachBus_RX bus NULL pointer.");`
`168`	`168`	`uart_t bus = (uart_t )busptr;`
	`169`	`+ uart_set_loop_back(bus->num, false); // disable loopback`
`169`	`170`	`return _uartDetachPins(bus->num, bus->_rxPin, UART_PIN_NO_CHANGE, UART_PIN_NO_CHANGE, UART_PIN_NO_CHANGE);`
`170`	`171`	`}`
`171`	`172`
`172`	`173`	`static bool _uartDetachBus_TX(void *busptr) {`
`173`	`174`	`// sanity check - it should never happen`
`174`	`175`	`assert(busptr && "_uartDetachBus_TX bus NULL pointer.");`
`175`	`176`	`uart_t bus = (uart_t )busptr;`
	`177`	`+ uart_set_loop_back(bus->num, false); // disable loopback`
`176`	`178`	`return _uartDetachPins(bus->num, UART_PIN_NO_CHANGE, bus->_txPin, UART_PIN_NO_CHANGE, UART_PIN_NO_CHANGE);`
`177`	`179`	`}`
`178`	`180`