Skip to content

Commit b72e866

Browse files
committed
fix(zigbee): mention Carbon dioxide delta reporting is not supported
1 parent 44e1559 commit b72e866

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

Diff for: libraries/Zigbee/src/ep/ZigbeeCarbonDioxideSensor.cpp

+4-1
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,9 @@ void ZigbeeCarbonDioxideSensor::setTolerance(float tolerance) {
4343
}
4444

4545
void ZigbeeCarbonDioxideSensor::setReporting(uint16_t min_interval, uint16_t max_interval, uint16_t delta) {
46+
if(delta > 0) {
47+
log_e("Delta reporting is currently not supported by the carbon dioxide sensor");
48+
}
4649
esp_zb_zcl_reporting_info_t reporting_info = {
4750
.direction = ESP_ZB_ZCL_CMD_DIRECTION_TO_SRV,
4851
.ep = _endpoint,
@@ -57,7 +60,7 @@ void ZigbeeCarbonDioxideSensor::setReporting(uint16_t min_interval, uint16_t max
5760
.max_interval = max_interval,
5861
.delta =
5962
{
60-
.u16 = delta, // x ppm
63+
.u16 = delta,
6164
},
6265
.def_min_interval = min_interval,
6366
.def_max_interval = max_interval,

Diff for: libraries/Zigbee/src/ep/ZigbeeCarbonDioxideSensor.h

+1
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ class ZigbeeCarbonDioxideSensor : public ZigbeeEP {
4949
void setTolerance(float tolerance);
5050

5151
// Set the reporting interval for carbon dioxide measurement in seconds and delta (carbon dioxide change in ppm)
52+
// NOTE: Delta reporting is currently not supported by the carbon dioxide sensor
5253
void setReporting(uint16_t min_interval, uint16_t max_interval, uint16_t delta);
5354

5455
// Report the carbon dioxide value

0 commit comments

Comments
 (0)