Skip to content

Commit a7e2e64

Browse files
Apply suggestions from code review
Co-authored-by: Lucas Saavedra Vaz <[email protected]>
1 parent 57339ba commit a7e2e64

7 files changed

+14
-0
lines changed

Diff for: libraries/Zigbee/src/ep/ZigbeeCarbonDioxideSensor.cpp

+2
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ void ZigbeeCarbonDioxideSensor::setReporting(uint16_t min_interval, uint16_t max
4646
if(delta > 0) {
4747
log_e("Delta reporting is currently not supported by the carbon dioxide sensor");
4848
}
49+
// clang-format off
4950
esp_zb_zcl_reporting_info_t reporting_info = {
5051
.direction = ESP_ZB_ZCL_CMD_DIRECTION_TO_SRV,
5152
.ep = _endpoint,
@@ -72,6 +73,7 @@ void ZigbeeCarbonDioxideSensor::setReporting(uint16_t min_interval, uint16_t max
7273
},
7374
.manuf_code = ESP_ZB_ZCL_ATTR_NON_MANUFACTURER_SPECIFIC,
7475
};
76+
// clang-format on
7577
esp_zb_lock_acquire(portMAX_DELAY);
7678
esp_zb_zcl_update_reporting_info(&reporting_info);
7779
esp_zb_lock_release();

Diff for: libraries/Zigbee/src/ep/ZigbeeCarbonDioxideSensor.h

+2
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
#include "ZigbeeEP.h"
1010
#include "ha/esp_zigbee_ha_standard.h"
1111

12+
// clang-format off
1213
#define ZIGBEE_DEFAULT_CARBON_DIOXIDE_SENSOR_CONFIG() \
1314
{ \
1415
.basic_cfg = \
@@ -27,6 +28,7 @@
2728
.max_measured_value = 1.0, \
2829
}, \
2930
}
31+
// clang-format on
3032

3133
typedef struct zigbee_carbon_dioxide_sensor_cfg_s {
3234
esp_zb_basic_cluster_cfg_t basic_cfg;

Diff for: libraries/Zigbee/src/ep/ZigbeeFlowSensor.cpp

+2
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ void ZigbeeFlowSensor::setTolerance(float tolerance) {
4444
}
4545

4646
void ZigbeeFlowSensor::setReporting(uint16_t min_interval, uint16_t max_interval, float delta) {
47+
// clang-format off
4748
esp_zb_zcl_reporting_info_t reporting_info = {
4849
.direction = ESP_ZB_ZCL_CMD_DIRECTION_TO_SRV,
4950
.ep = _endpoint,
@@ -70,6 +71,7 @@ void ZigbeeFlowSensor::setReporting(uint16_t min_interval, uint16_t max_interval
7071
},
7172
.manuf_code = ESP_ZB_ZCL_ATTR_NON_MANUFACTURER_SPECIFIC,
7273
};
74+
// clang-format on
7375
esp_zb_lock_acquire(portMAX_DELAY);
7476
esp_zb_zcl_update_reporting_info(&reporting_info);
7577
esp_zb_lock_release();

Diff for: libraries/Zigbee/src/ep/ZigbeeFlowSensor.h

+2
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
#include "ZigbeeEP.h"
1010
#include "ha/esp_zigbee_ha_standard.h"
1111

12+
// clang-format off
1213
#define ZIGBEE_DEFAULT_FLOW_SENSOR_CONFIG() \
1314
{ \
1415
.basic_cfg = \
@@ -27,6 +28,7 @@
2728
.max_value = 0x7FFF, \
2829
}, \
2930
}
31+
// clang-format on
3032

3133
typedef struct zigbee_flow_sensor_cfg_s {
3234
esp_zb_basic_cluster_cfg_t basic_cfg;

Diff for: libraries/Zigbee/src/ep/ZigbeeOccupancySensor.h

+2
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
#include "ZigbeeEP.h"
1010
#include "ha/esp_zigbee_ha_standard.h"
1111

12+
// clang-format off
1213
#define ZIGBEE_DEFAULT_OCCUPANCY_SENSOR_CONFIG() \
1314
{ \
1415
.basic_cfg = \
@@ -27,6 +28,7 @@
2728
.sensor_type_bitmap = (1 << ESP_ZB_ZCL_OCCUPANCY_SENSING_OCCUPANCY_SENSOR_TYPE_PIR), \
2829
}, \
2930
}
31+
// clang-format on
3032

3133
typedef struct zigbee_occupancy_sensor_cfg_s {
3234
esp_zb_basic_cluster_cfg_t basic_cfg;

Diff for: libraries/Zigbee/src/ep/ZigbeePressureSensor.cpp

+2
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ void ZigbeePressureSensor::setTolerance(uint16_t tolerance) {
4141
}
4242

4343
void ZigbeePressureSensor::setReporting(uint16_t min_interval, uint16_t max_interval, uint16_t delta) {
44+
// clang-format off
4445
esp_zb_zcl_reporting_info_t reporting_info = {
4546
.direction = ESP_ZB_ZCL_CMD_DIRECTION_TO_SRV,
4647
.ep = _endpoint,
@@ -67,6 +68,7 @@ void ZigbeePressureSensor::setReporting(uint16_t min_interval, uint16_t max_inte
6768
},
6869
.manuf_code = ESP_ZB_ZCL_ATTR_NON_MANUFACTURER_SPECIFIC,
6970
};
71+
// clang-format on
7072
esp_zb_lock_acquire(portMAX_DELAY);
7173
esp_zb_zcl_update_reporting_info(&reporting_info);
7274
esp_zb_lock_release();

Diff for: libraries/Zigbee/src/ep/ZigbeePressureSensor.h

+2
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
#include "ZigbeeEP.h"
1010
#include "ha/esp_zigbee_ha_standard.h"
1111

12+
// clang-format off
1213
#define ZIGBEE_DEFAULT_PRESSURE_SENSOR_CONFIG() \
1314
{ \
1415
.basic_cfg = \
@@ -27,6 +28,7 @@
2728
.max_value = ESP_ZB_ZCL_PATTR_RESSURE_MEASUREMENT_MAX_VALUE_DEFAULT_VALUE, \
2829
}, \
2930
}
31+
// clang-format on
3032

3133
typedef struct zigbee_pressure_sensor_cfg_s {
3234
esp_zb_basic_cluster_cfg_t basic_cfg;

0 commit comments

Comments
 (0)