Skip to content

Commit 9e60bbe

Browse files
TD-erpre-commit-ci-lite[bot]
TD-er
and
pre-commit-ci-lite[bot]
authored
[WebServer] Mark functions as const + reduce copy of strings (#10339)
* [WebServer] Mark functions as const + reduce copy of strings * ci(pre-commit): Apply automatic fixes --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
1 parent ac0de43 commit 9e60bbe

File tree

3 files changed

+31
-31
lines changed

3 files changed

+31
-31
lines changed

Diff for: ‎libraries/WebServer/src/Parsing.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,7 @@ bool WebServer::_collectHeader(const char *headerName, const char *headerValue)
280280
return false;
281281
}
282282

283-
void WebServer::_parseArguments(String data) {
283+
void WebServer::_parseArguments(const String &data) {
284284
log_v("args: %s", data.c_str());
285285
if (_currentArgs) {
286286
delete[] _currentArgs;
@@ -387,7 +387,7 @@ int WebServer::_uploadReadByte(NetworkClient &client) {
387387
return res;
388388
}
389389

390-
bool WebServer::_parseForm(NetworkClient &client, String boundary, uint32_t len) {
390+
bool WebServer::_parseForm(NetworkClient &client, const String &boundary, uint32_t len) {
391391
(void)len;
392392
log_v("Parse Form: Boundary: %s Length: %d", boundary.c_str(), len);
393393
String line;

Diff for: ‎libraries/WebServer/src/WebServer.cpp

+12-12
Original file line numberDiff line numberDiff line change
@@ -674,14 +674,14 @@ void WebServer::_streamFileCore(const size_t fileSize, const String &fileName, c
674674
send(code, contentType, "");
675675
}
676676

677-
String WebServer::pathArg(unsigned int i) {
677+
String WebServer::pathArg(unsigned int i) const {
678678
if (_currentHandler != nullptr) {
679679
return _currentHandler->pathArg(i);
680680
}
681681
return "";
682682
}
683683

684-
String WebServer::arg(String name) {
684+
String WebServer::arg(const String &name) const {
685685
for (int j = 0; j < _postArgsLen; ++j) {
686686
if (_postArgs[j].key == name) {
687687
return _postArgs[j].value;
@@ -695,25 +695,25 @@ String WebServer::arg(String name) {
695695
return "";
696696
}
697697

698-
String WebServer::arg(int i) {
698+
String WebServer::arg(int i) const {
699699
if (i < _currentArgCount) {
700700
return _currentArgs[i].value;
701701
}
702702
return "";
703703
}
704704

705-
String WebServer::argName(int i) {
705+
String WebServer::argName(int i) const {
706706
if (i < _currentArgCount) {
707707
return _currentArgs[i].key;
708708
}
709709
return "";
710710
}
711711

712-
int WebServer::args() {
712+
int WebServer::args() const {
713713
return _currentArgCount;
714714
}
715715

716-
bool WebServer::hasArg(String name) {
716+
bool WebServer::hasArg(const String &name) const {
717717
for (int j = 0; j < _postArgsLen; ++j) {
718718
if (_postArgs[j].key == name) {
719719
return true;
@@ -727,7 +727,7 @@ bool WebServer::hasArg(String name) {
727727
return false;
728728
}
729729

730-
String WebServer::header(String name) {
730+
String WebServer::header(const String &name) const {
731731
for (int i = 0; i < _headerKeysCount; ++i) {
732732
if (_currentHeaders[i].key.equalsIgnoreCase(name)) {
733733
return _currentHeaders[i].value;
@@ -749,25 +749,25 @@ void WebServer::collectHeaders(const char *headerKeys[], const size_t headerKeys
749749
}
750750
}
751751

752-
String WebServer::header(int i) {
752+
String WebServer::header(int i) const {
753753
if (i < _headerKeysCount) {
754754
return _currentHeaders[i].value;
755755
}
756756
return "";
757757
}
758758

759-
String WebServer::headerName(int i) {
759+
String WebServer::headerName(int i) const {
760760
if (i < _headerKeysCount) {
761761
return _currentHeaders[i].key;
762762
}
763763
return "";
764764
}
765765

766-
int WebServer::headers() {
766+
int WebServer::headers() const {
767767
return _headerKeysCount;
768768
}
769769

770-
bool WebServer::hasHeader(String name) {
770+
bool WebServer::hasHeader(const String &name) const {
771771
for (int i = 0; i < _headerKeysCount; ++i) {
772772
if ((_currentHeaders[i].key.equalsIgnoreCase(name)) && (_currentHeaders[i].value.length() > 0)) {
773773
return true;
@@ -776,7 +776,7 @@ bool WebServer::hasHeader(String name) {
776776
return false;
777777
}
778778

779-
String WebServer::hostHeader() {
779+
String WebServer::hostHeader() const {
780780
return _hostHeader;
781781
}
782782

Diff for: ‎libraries/WebServer/src/WebServer.h

+17-17
Original file line numberDiff line numberDiff line change
@@ -158,10 +158,10 @@ class WebServer {
158158
void onNotFound(THandlerFunction fn); //called when handler is not assigned
159159
void onFileUpload(THandlerFunction ufn); //handle file uploads
160160

161-
String uri() {
161+
String uri() const {
162162
return _currentUri;
163163
}
164-
HTTPMethod method() {
164+
HTTPMethod method() const {
165165
return _currentMethod;
166166
}
167167
virtual NetworkClient &client() {
@@ -174,24 +174,24 @@ class WebServer {
174174
return *_currentRaw;
175175
}
176176

177-
String pathArg(unsigned int i); // get request path argument by number
178-
String arg(String name); // get request argument value by name
179-
String arg(int i); // get request argument value by number
180-
String argName(int i); // get request argument name by number
181-
int args(); // get arguments count
182-
bool hasArg(String name); // check if argument exists
177+
String pathArg(unsigned int i) const; // get request path argument by number
178+
String arg(const String &name) const; // get request argument value by name
179+
String arg(int i) const; // get request argument value by number
180+
String argName(int i) const; // get request argument name by number
181+
int args() const; // get arguments count
182+
bool hasArg(const String &name) const; // check if argument exists
183183
void collectHeaders(const char *headerKeys[], const size_t headerKeysCount); // set the request headers to collect
184-
String header(String name); // get request header value by name
185-
String header(int i); // get request header value by number
186-
String headerName(int i); // get request header name by number
187-
int headers(); // get header count
188-
bool hasHeader(String name); // check if header exists
184+
String header(const String &name) const; // get request header value by name
185+
String header(int i) const; // get request header value by number
186+
String headerName(int i) const; // get request header name by number
187+
int headers() const; // get header count
188+
bool hasHeader(const String &name) const; // check if header exists
189189

190-
int clientContentLength() {
190+
int clientContentLength() const {
191191
return _clientContentLength;
192192
} // return "content-length" of incoming HTTP header from "_currentClient"
193193

194-
String hostHeader(); // get request host header if available or empty String if not
194+
String hostHeader() const; // get request host header if available or empty String if not
195195

196196
// send response to the client
197197
// code - HTTP response code, can be 200 or 404
@@ -240,9 +240,9 @@ class WebServer {
240240
void _handleRequest();
241241
void _finalizeResponse();
242242
bool _parseRequest(NetworkClient &client);
243-
void _parseArguments(String data);
243+
void _parseArguments(const String &data);
244244
static String _responseCodeToString(int code);
245-
bool _parseForm(NetworkClient &client, String boundary, uint32_t len);
245+
bool _parseForm(NetworkClient &client, const String &boundary, uint32_t len);
246246
bool _parseFormUploadAborted();
247247
void _uploadWriteByte(uint8_t b);
248248
int _uploadReadByte(NetworkClient &client);

0 commit comments

Comments
 (0)