Skip to content

Commit 9cb5dd5

Browse files
committed
fix(client): Make flush() call clear() and deprecate it
This is a compromise for issues caused by #9453
1 parent cd3d0bf commit 9cb5dd5

File tree

4 files changed

+8
-2
lines changed

4 files changed

+8
-2
lines changed

Diff for: libraries/Network/src/NetworkClient.cpp

+3-1
Original file line numberDiff line numberDiff line change
@@ -369,7 +369,9 @@ int NetworkClient::read() {
369369
return data;
370370
}
371371

372-
void NetworkClient::flush() {}
372+
void NetworkClient::flush() {
373+
clear();
374+
}
373375

374376
size_t NetworkClient::write(const uint8_t *buf, size_t size) {
375377
int res = 0;

Diff for: libraries/Network/src/NetworkClient.h

+1
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ class NetworkClient : public ESPLwIPClient {
5656
size_t write(const uint8_t *buf, size_t size);
5757
size_t write_P(PGM_P buf, size_t size);
5858
size_t write(Stream &stream);
59+
[[deprecated("Use clear() instead.")]]
5960
void flush(); // Print::flush tx
6061
int available();
6162
int read();

Diff for: libraries/Network/src/NetworkUdp.cpp

+3-1
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,9 @@ size_t NetworkUDP::write(const uint8_t *buffer, size_t size) {
288288
return i;
289289
}
290290

291-
void NetworkUDP::flush() {}
291+
void NetworkUDP::flush() {
292+
clear();
293+
}
292294

293295
int NetworkUDP::parsePacket() {
294296
if (rx_buffer) {

Diff for: libraries/Network/src/NetworkUdp.h

+1
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ class NetworkUDP : public UDP {
6464
int endPacket();
6565
size_t write(uint8_t);
6666
size_t write(const uint8_t *buffer, size_t size);
67+
[[deprecated("Use clear() instead.")]]
6768
void flush(); // Print::flush tx
6869
int parsePacket();
6970
int available();

0 commit comments

Comments
 (0)