Skip to content

Commit 6759dd7

Browse files
committed
fix(matter): removing commented code lines and fixing log levels
1 parent 7d3ac5c commit 6759dd7

File tree

2 files changed

+3
-10
lines changed

2 files changed

+3
-10
lines changed

libraries/Matter/src/MatterEndPoint.h

+3-3
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ class MatterEndPoint {
7272
log_v("GET_VAL Suceess for cluster %d, attribute %d with value %d", cluster_id, attribute_id, attrVal->val.u32);
7373
return true;
7474
}
75-
log_v("GET_VAL FAILED! for cluster %d, attribute %d with value %d", cluster_id, attribute_id, attrVal->val.u32);
75+
log_e("GET_VAL FAILED! for cluster %d, attribute %d with value %d", cluster_id, attribute_id, attrVal->val.u32);
7676
return false;
7777
}
7878

@@ -86,7 +86,7 @@ class MatterEndPoint {
8686
log_v("SET_VAL Suceess for cluster %d, attribute %d with value %d", cluster_id, attribute_id, attrVal->val.u32);
8787
return true;
8888
}
89-
log_v("SET_VAL FAILED! for cluster %d, attribute %d with value %d", cluster_id, attribute_id, attrVal->val.u32);
89+
log_e("SET_VAL FAILED! for cluster %d, attribute %d with value %d", cluster_id, attribute_id, attrVal->val.u32);
9090
return false;
9191
}
9292

@@ -96,7 +96,7 @@ class MatterEndPoint {
9696
log_v("Update Suceess for cluster %d, attribute %d with value %d", cluster_id, attribute_id, attrVal->val.u32);
9797
return true;
9898
}
99-
log_v("Update FAILED! for cluster %d, attribute %d with value %d", cluster_id, attribute_id, attrVal->val.u32);
99+
log_e("Update FAILED! for cluster %d, attribute %d with value %d", cluster_id, attribute_id, attrVal->val.u32);
100100
return false;
101101
}
102102

libraries/Matter/src/MatterEndpoints/MatterFan.cpp

-7
Original file line numberDiff line numberDiff line change
@@ -50,13 +50,6 @@ bool MatterFan::attributeChangeCB(uint16_t endpoint_id, uint32_t cluster_id, uin
5050
log_i("===> Fan Attr update callback: endpoint: %u, cluster: %u, attribute: %u, val: %u", endpoint_id, cluster_id, attribute_id, val->val.u32);
5151

5252
if (endpoint_id == getEndPointId() && cluster_id == FanControl::Id) {
53-
//endpoint_t *endpoint = endpoint::get(node::get(), endpoint_id);
54-
//cluster_t *cluster = cluster::get(endpoint, FanControl::Id);
55-
56-
//attribute_t *attr_percent_setting = attribute::get(cluster, Attributes::PercentSetting::Id);
57-
//attribute_t *attribute_percent_current = attribute::get(cluster, Attributes::PercentCurrent::Id);
58-
//attribute_t *attr_fan_mode = attribute::get(cluster, Attributes::FanMode::Id);
59-
6053
switch (attribute_id) {
6154
case FanControl::Attributes::FanMode::Id:
6255
log_d("FanControl Fan Mode changed to %s (%x)", val->val.u8 < 7 ? fanModeString[val->val.u8] : "Unknown", val->val.u8);

0 commit comments

Comments
 (0)