Skip to content

Commit 5fe5f77

Browse files
Apply @SuGlider suggestions from code review
Co-authored-by: Rodrigo Garcia <[email protected]>
1 parent 705b1ee commit 5fe5f77

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

libraries/ESP_NOW/src/ESP32_NOW_Serial.cpp

+8-8
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@ ESP_NOW_Serial_Class::~ESP_NOW_Serial_Class(){
2727

2828
size_t ESP_NOW_Serial_Class::setTxBufferSize(size_t tx_queue_len){
2929
if(tx_ring_buf){
30-
if(!tx_queue_len){
31-
vRingbufferDelete(tx_ring_buf);
32-
tx_ring_buf = NULL;
33-
}
30+
vRingbufferDelete(tx_ring_buf);
31+
tx_ring_buf = NULL;
32+
}
33+
if(!tx_queue_len){
3434
return 0;
3535
}
3636
tx_ring_buf = xRingbufferCreate(tx_queue_len, RINGBUF_TYPE_BYTEBUF);
@@ -42,10 +42,10 @@ size_t ESP_NOW_Serial_Class::setTxBufferSize(size_t tx_queue_len){
4242

4343
size_t ESP_NOW_Serial_Class::setRxBufferSize(size_t rx_queue_len){
4444
if(rx_queue){
45-
if(!rx_queue_len){
46-
vQueueDelete(rx_queue);
47-
rx_queue = NULL;
48-
}
45+
vQueueDelete(rx_queue);
46+
rx_queue = NULL;
47+
}
48+
if(!rx_queue_len){
4949
return 0;
5050
}
5151
rx_queue = xQueueCreate(rx_queue_len, sizeof(uint8_t));

0 commit comments

Comments
 (0)