Skip to content

Commit 57410d8

Browse files
authored
fix(uart): using uart number as parameter in uartSetClockSource()
1 parent aa7a37f commit 57410d8

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

cores/esp32/esp32-hal-uart.c

+5-6
Original file line numberDiff line numberDiff line change
@@ -1153,14 +1153,12 @@ bool uartSetMode(uart_t *uart, uart_mode_t mode) {
11531153

11541154
// this function will set the uart clock source
11551155
// it must be called before uartBegin(), otherwise it won't change any thing.
1156-
bool uartSetClockSource(uart_t *uart, uart_sclk_t clkSrc) {
1157-
if (uart == NULL) {
1158-
return false;
1159-
}
1160-
if (uart_is_driver_installed(uart->num)) {
1161-
log_e("No Clock Source change was done. This function must be called before beginning UART%d.", uart->num);
1156+
bool uartSetClockSource(uint8_t uartNum, uart_sclk_t clkSrc) {
1157+
if (uartNum >= SOC_UART_NUM) {
1158+
log_e("UART%d is invalid. This device has %d UARTs, from 0 to %d.", uartNum, SOC_UART_NUM, SOC_UART_NUM - 1);
11621159
return false;
11631160
}
1161+
uart_t *uart = &_uart_bus_array[uartNum];
11641162
#if SOC_UART_LP_NUM >= 1
11651163
if (uart->num >= SOC_UART_HP_NUM) {
11661164
switch (clkSrc) {
@@ -1179,6 +1177,7 @@ bool uartSetClockSource(uart_t *uart, uart_sclk_t clkSrc) {
11791177
{
11801178
uart->_uart_clock_source = clkSrc;
11811179
}
1180+
//log_i("UART%d set clock source to %d", uart->num, uart->_uart_clock_source);
11821181
return true;
11831182
}
11841183

0 commit comments

Comments
 (0)