Merge branch 'espressif:master' into sylque-patch-1

Author: sylque

Diff for: .editorconfig

@@ -18,7 +18,7 @@ indent_size = 2
 indent_style = space
 
 [*.{bash,sh}]
-indent_size = 2
+indent_size = 4
 indent_style = space
 
 [*.{c,cc,cp,cpp,cxx,h,hh,hpp,hxx,ii,inl,ino,ixx,pde,tpl,tpp,txx}]

Diff for: .github/ISSUE_TEMPLATE/Issue-report.yml

@@ -41,6 +41,8 @@ body:
       options:
         - latest master (checkout manually)
         - latest development Release Candidate (RC-X)
+        - v3.0.6
+        - v3.0.5
         - v3.0.4
         - v3.0.3
         - v3.0.2

Diff for: .github/scripts/find_new_boards.sh

@@ -2,59 +2,39 @@
 
 # Get inputs from command
 owner_repository=$1
-pr_number=$2
+base_ref=$2
 
-url="https://api.github.com/repos/$owner_repository/pulls/$pr_number/files"
-echo $url
+# Download the boards.txt file from the base branch
+curl -L -o boards_base.txt https://raw.githubusercontent.com/$owner_repository/$base_ref/boards.txt
 
-# Get changes in boards.txt file from PR
-Patch=$(curl $url | jq -r '.[] | select(.filename == "boards.txt") | .patch ')
+# Compare boards.txt file in the repo with the modified file from PR
+diff=$(diff -u boards_base.txt boards.txt)
 
-# Extract only changed lines number and count
-substring_patch=$(echo "$Patch" | grep -o '@@[^@]*@@')
-
-params_array=()
+# Check if the diff is empty
+if [ -z "$diff" ]
+then
+    echo "No changes in boards.txt file"
+    echo "FQBNS="
+    exit 0
+fi
 
-IFS=$'\n' read -d '' -ra params <<< $(echo "$substring_patch" | grep -oE '[-+][0-9]+,[0-9]+')
+# Extract added or modified lines (lines starting with '+' or '-')
+modified_lines=$(echo "$diff" | grep -E '^[+-][^+-]')
 
-for param in "${params[@]}"
-do
-    echo "The parameter is $param"
-    params_array+=("$param")
-done
+# Print the modified lines for debugging
+echo "Modified lines:"
+echo "$modified_lines"
 
 boards_array=()
 previous_board=""
-file="boards.txt"
 
-# Loop through boards.txt file and extract all boards that were added
-for (( c=0; c<${#params_array[@]}; c+=2 ))
+# Extract board names from the modified lines, and add them to the boards_array
+while read -r line
 do
-    deletion_count=$( echo "${params_array[c]}" | cut -d',' -f2 | cut -d' ' -f1 )
-    addition_line=$( echo "${params_array[c+1]}" | cut -d'+' -f2 | cut -d',' -f1 )
-    addition_count=$( echo "${params_array[c+1]}" | cut -d'+' -f2 | cut -d',' -f2 | cut -d' ' -f1 )
-    addition_end=$(($addition_line+$addition_count))
-    
-    addition_line=$(($addition_line + 3))
-    addition_end=$(($addition_end - $deletion_count))
-
-    echo $addition_line
-    echo $addition_end
-
-    i=0
-
-    while read -r line
-    do
-    i=$((i+1))
-    if [ $i -lt $addition_line ]
-    then
-    continue
-    elif [ $i -gt $addition_end ]
-    then
-    break
-    fi
     board_name=$(echo "$line" | cut -d '.' -f1 | cut -d '#' -f1)
-    if [ "$board_name" != "" ] && [ "$board_name" != "esp32_family" ]
+    # remove + or - from the board name at the beginning
+    board_name=$(echo "$board_name" | sed 's/^[+-]//')
+    if [ "$board_name" != "" ] && [ "$board_name" != "+" ] && [ "$board_name" != "-" ] && [ "$board_name" != "esp32_family" ]
     then
         if [ "$board_name" != "$previous_board" ]
         then
@@ -63,8 +43,7 @@ do
             echo "Added 'espressif:esp32:$board_name' to array"
         fi
     fi
-    done < "$file"
-done
+done <<< "$modified_lines"
 
 # Create JSON like string with all boards found and pass it to env variable
 board_count=${#boards_array[@]}

Diff for: .github/scripts/install-platformio-esp32.sh

@@ -7,6 +7,9 @@ TOOLCHAIN_VERSION="12.2.0+20230208"
 ESPTOOLPY_VERSION="~1.40501.0"
 ESPRESSIF_ORGANIZATION_NAME="espressif"
 SDKCONFIG_DIR="$PLATFORMIO_ESP32_PATH/tools/esp32-arduino-libs"
+SCRIPTS_DIR="./.github/scripts"
+COUNT_SKETCHES="${SCRIPTS_DIR}/sketch_utils.sh count"
+CHECK_REQUIREMENTS="${SCRIPTS_DIR}/sketch_utils.sh check_requirements"
 
 echo "Installing Python Wheel ..."
 pip install wheel > /dev/null 2>&1
@@ -74,47 +77,6 @@ function build_pio_sketch(){ # build_pio_sketch <board> <options> <path-to-ino>
     python -m platformio ci --board "$board" "$sketch_dir" --project-option="$options"
 }
 
-function count_sketches(){ # count_sketches <examples-path>
-    local examples="$1"
-    rm -rf sketches.txt
-    if [ ! -d "$examples" ]; then
-        touch sketches.txt
-        return 0
-    fi
-    local sketches=$(find $examples -name *.ino)
-    local sketchnum=0
-    for sketch in $sketches; do
-        local sketchdir=$(dirname $sketch)
-        local sketchdirname=$(basename $sketchdir)
-        local sketchname=$(basename $sketch)
-        if [[ "${sketchdirname}.ino" != "$sketchname" ]]; then
-            continue
-        elif [ -f $sketchdir/ci.json ]; then
-            # If the target is listed as false, skip the sketch. Otherwise, include it.
-            is_target=$(jq -r '.targets[esp32]' $sketchdir/ci.json)
-            if [[ "$is_target" == "false" ]]; then
-                continue
-            fi
-
-            # Check if the sketch requires any configuration options
-            requirements=$(jq -r '.requires[]? // empty' $sketchdir/ci.json)
-            if [[ "$requirements" != "null" ]] || [[ "$requirements" != "" ]]; then
-                for requirement in $requirements; do
-                    requirement=$(echo $requirement | xargs)
-                    found_line=$(grep -E "^$requirement" "$SDKCONFIG_DIR/esp32/sdkconfig")
-                    if [[ "$found_line" == "" ]]; then
-                        continue 2
-                    fi
-                done
-            fi
-        fi
-
-        echo $sketch >> sketches.txt
-        sketchnum=$(($sketchnum + 1))
-    done
-    return $sketchnum
-}
-
 function build_pio_sketches(){ # build_pio_sketches <board> <options> <examples-path> <chunk> <total-chunks>
     if [ "$#" -lt 3 ]; then
         echo "ERROR: Illegal number of parameters"
@@ -143,7 +105,7 @@ function build_pio_sketches(){ # build_pio_sketches <board> <options> <examples-
     fi
 
     set +e
-    count_sketches "$examples"
+    ${COUNT_SKETCHES} "$examples" "esp32"
     local sketchcount=$?
     set -e
     local sketches=$(cat sketches.txt)
@@ -187,16 +149,9 @@ function build_pio_sketches(){ # build_pio_sketches <board> <options> <examples-
                 continue
             fi
 
-            # Check if the sketch requires any configuration options
-            requirements=$(jq -r '.requires[]? // empty' $sketchdir/ci.json)
-            if [[ "$requirements" != "null" ]] || [[ "$requirements" != "" ]]; then
-                for requirement in $requirements; do
-                    requirement=$(echo $requirement | xargs)
-                    found_line=$(grep -E "^$requirement" "$SDKCONFIG_DIR/esp32/sdkconfig")
-                    if [[ "$found_line" == "" ]]; then
-                        continue 2
-                    fi
-                done
+            local has_requirements=$(${CHECK_REQUIREMENTS} $sketchdir "$SDKCONFIG_DIR/esp32/sdkconfig")
+            if [ "$has_requirements" == "0" ]; then
+                continue
             fi
         fi
 

Diff for: .github/scripts/set_push_chunks.sh

@@ -4,73 +4,73 @@ build_all=false
 chunks_count=0
 
 if [[ $CORE_CHANGED == 'true' ]] || [[ $IS_PR != 'true' ]]; then
-  echo "Core files changed or not a PR. Building all."
-  build_all=true
-  chunks_count=$MAX_CHUNKS
+    echo "Core files changed or not a PR. Building all."
+    build_all=true
+    chunks_count=$MAX_CHUNKS
 elif [[ $LIB_CHANGED == 'true' ]]; then
-  echo "Libraries changed. Building only affected sketches."
-  if [[ $NETWORKING_CHANGED == 'true' ]]; then
-    echo "Networking libraries changed. Building networking related sketches."
-    networking_sketches="$(find libraries/WiFi -name *.ino) "
-    networking_sketches+="$(find libraries/Ethernet -name *.ino) "
-    networking_sketches+="$(find libraries/PPP -name *.ino) "
-    networking_sketches+="$(find libraries/NetworkClientSecure -name *.ino) "
-    networking_sketches+="$(find libraries/WebServer -name *.ino) "
-  fi
-  if [[ $FS_CHANGED == 'true' ]]; then
-    echo "FS libraries changed. Building FS related sketches."
-    fs_sketches="$(find libraries/SD -name *.ino) "
-    fs_sketches+="$(find libraries/SD_MMC -name *.ino) "
-    fs_sketches+="$(find libraries/SPIFFS -name *.ino) "
-    fs_sketches+="$(find libraries/LittleFS -name *.ino) "
-    fs_sketches+="$(find libraries/FFat -name *.ino) "
-  fi
-  sketches="$networking_sketches $fs_sketches"
-  for file in $LIB_FILES; do
-      if [[ $file == *.ino ]]; then
-          # If file ends with .ino, add it to the list of sketches
-          echo "Sketch found: $file"
-          sketches+="$file "
-      elif [[ $(basename $(dirname $file)) == "src" ]]; then
-          # If file is in a src directory, find all sketches in the parent/examples directory
-          echo "Library src file found: $file"
-          lib=$(dirname $(dirname $file))
-          if [[ -d $lib/examples ]]; then
-              lib_sketches=$(find $lib/examples -name *.ino)
-              sketches+="$lib_sketches "
-              echo "Library sketches: $lib_sketches"
-          fi
-      else
-          # If file is in a example folder but it is not a sketch, find all sketches in the current directory
-          echo "File in example folder found: $file"
-          sketch=$(find $(dirname $file) -name *.ino)
-          sketches+="$sketch "
-          echo "Sketch in example folder: $sketch"
-      fi
-      echo ""
-  done
+    echo "Libraries changed. Building only affected sketches."
+    if [[ $NETWORKING_CHANGED == 'true' ]]; then
+        echo "Networking libraries changed. Building networking related sketches."
+        networking_sketches="$(find libraries/WiFi -name *.ino) "
+        networking_sketches+="$(find libraries/Ethernet -name *.ino) "
+        networking_sketches+="$(find libraries/PPP -name *.ino) "
+        networking_sketches+="$(find libraries/NetworkClientSecure -name *.ino) "
+        networking_sketches+="$(find libraries/WebServer -name *.ino) "
+    fi
+    if [[ $FS_CHANGED == 'true' ]]; then
+        echo "FS libraries changed. Building FS related sketches."
+        fs_sketches="$(find libraries/SD -name *.ino) "
+        fs_sketches+="$(find libraries/SD_MMC -name *.ino) "
+        fs_sketches+="$(find libraries/SPIFFS -name *.ino) "
+        fs_sketches+="$(find libraries/LittleFS -name *.ino) "
+        fs_sketches+="$(find libraries/FFat -name *.ino) "
+    fi
+    sketches="$networking_sketches $fs_sketches"
+    for file in $LIB_FILES; do
+        lib=$(echo $file | awk -F "/" '{print $1"/"$2}')
+        if [[ "$file" == *.ino ]]; then
+            # If file ends with .ino, add it to the list of sketches
+            echo "Sketch found: $file"
+            sketches+="$file "
+        elif [[ "$file" == "$lib/src/"* ]]; then
+            # If file is inside the src directory, find all sketches in the lib/examples directory
+            echo "Library src file found: $file"
+            if [[ -d $lib/examples ]]; then
+                lib_sketches=$(find $lib/examples -name *.ino)
+                sketches+="$lib_sketches "
+                echo "Library sketches: $lib_sketches"
+            fi
+        else
+            # If file is in a example folder but it is not a sketch, find all sketches in the current directory
+            echo "File in example folder found: $file"
+            sketch=$(find $(dirname $file) -name *.ino)
+            sketches+="$sketch "
+            echo "Sketch in example folder: $sketch"
+        fi
+        echo ""
+    done
 fi
 
 if [[ -n $sketches ]]; then
-  # Remove duplicates
-  sketches=$(echo $sketches | tr ' ' '\n' | sort | uniq)
-  for sketch in $sketches; do
-      echo $sketch >> sketches_found.txt
-      chunks_count=$((chunks_count+1))
-  done
-  echo "Number of sketches found: $chunks_count"
-  echo "Sketches:"
-  echo "$sketches"
+    # Remove duplicates
+    sketches=$(echo $sketches | tr ' ' '\n' | sort | uniq)
+    for sketch in $sketches; do
+        echo $sketch >> sketches_found.txt
+        chunks_count=$((chunks_count+1))
+    done
+    echo "Number of sketches found: $chunks_count"
+    echo "Sketches:"
+    echo "$sketches"
 
-  if [[ $chunks_count -gt $MAX_CHUNKS ]]; then
-    echo "More sketches than the allowed number of chunks found. Limiting to $MAX_CHUNKS chunks."
-    chunks_count=$MAX_CHUNKS
-  fi
+    if [[ $chunks_count -gt $MAX_CHUNKS ]]; then
+        echo "More sketches than the allowed number of chunks found. Limiting to $MAX_CHUNKS chunks."
+        chunks_count=$MAX_CHUNKS
+    fi
 fi
 
 chunks='["0"'
 for i in $(seq 1 $(( $chunks_count - 1 )) ); do
-  chunks+=",\"$i\""
+    chunks+=",\"$i\""
 done
 chunks+="]"