Skip to content

Commit 328523f

Browse files
Schuemime-no-dev
authored andcommitted
Memory leak (#1672)
When a package of size 0 arrives, "buf" is created, but never released. (Sorry, that was my mistake in the last patch)
1 parent 7761ebd commit 328523f

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

Diff for: libraries/WiFi/src/WiFiUdp.cpp

+4-3
Original file line numberDiff line numberDiff line change
@@ -221,9 +221,10 @@ int WiFiUDP::parsePacket(){
221221
}
222222
remote_ip = IPAddress(si_other.sin_addr.s_addr);
223223
remote_port = ntohs(si_other.sin_port);
224-
if (len == 0) return 0;
225-
rx_buffer = new cbuf(len);
226-
rx_buffer->write(buf, len);
224+
if (len > 0) {
225+
rx_buffer = new cbuf(len);
226+
rx_buffer->write(buf, len);
227+
}
227228
delete[] buf;
228229
return len;
229230
}

0 commit comments

Comments
 (0)