WiFiClient - Properly initialize and check _rxBuffer (#8699)

lucasssvaz · pull[bot] · commit 2883503d9ed1 · 2024-07-17T13:05:03.000Z
diff --git a/libraries/WiFi/src/WiFiClient.cpp b/libraries/WiFi/src/WiFiClient.cpp
@@ -182,7 +182,7 @@ class WiFiClientSocketHandle {
     }
 };
 
-WiFiClient::WiFiClient():_connected(false),_timeout(WIFI_CLIENT_DEF_CONN_TIMEOUT_MS),next(NULL)
+WiFiClient::WiFiClient():_rxBuffer(nullptr),_connected(false),_timeout(WIFI_CLIENT_DEF_CONN_TIMEOUT_MS),next(NULL)
 {
 }
 
@@ -508,7 +508,9 @@ int WiFiClient::available()
 // Though flushing means to send all pending data,
 // seems that in Arduino it also means to clear RX
 void WiFiClient::flush() {
-    _rxBuffer->flush();
+    if (_rxBuffer != nullptr) {
+        _rxBuffer->flush();
+    }
 }
 
 uint8_t WiFiClient::connected()

Original file line number	Diff line number	Diff line change
`@@ -182,7 +182,7 @@ class WiFiClientSocketHandle {`
`182`	`182`	`}`
`183`	`183`	`};`
`184`	`184`
`185`		`-WiFiClient::WiFiClient():_connected(false),_timeout(WIFI_CLIENT_DEF_CONN_TIMEOUT_MS),next(NULL)`
	`185`	`+WiFiClient::WiFiClient():_rxBuffer(nullptr),_connected(false),_timeout(WIFI_CLIENT_DEF_CONN_TIMEOUT_MS),next(NULL)`
`186`	`186`	`{`
`187`	`187`	`}`
`188`	`188`
`@@ -508,7 +508,9 @@ int WiFiClient::available()`
`508`	`508`	`// Though flushing means to send all pending data,`
`509`	`509`	`// seems that in Arduino it also means to clear RX`
`510`	`510`	`void WiFiClient::flush() {`
`511`		`- _rxBuffer->flush();`
	`511`	`+ if (_rxBuffer != nullptr) {`
	`512`	`+ _rxBuffer->flush();`
	`513`	`+ }`
`512`	`514`	`}`
`513`	`515`
`514`	`516`	`uint8_t WiFiClient::connected()`