Skip to content

Commit 282f2d0

Browse files
committed
fix(example): Removed Serial and updated readme.
1 parent 57d7c3f commit 282f2d0

File tree

8 files changed

+11
-10
lines changed

8 files changed

+11
-10
lines changed

Diff for: libraries/ESP32/examples/Zigbee/Zigbee_Light_Bulb/.skip.esp32c6

Whitespace-only changes.

Diff for: libraries/ESP32/examples/Zigbee/Zigbee_Light_Bulb/.skip.esp32h2

Whitespace-only changes.

Diff for: libraries/ESP32/examples/Zigbee/Zigbee_Light_Bulb/README.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
# Arduino-ESP32 Zigbee Light Bulb Example
22

33
This example shows how to configure the Zigbee end device and use it as a HA on/off light bulb.
4-
This example is based on ESP-Zigbee-SDK example esp_zigbee_HA_sample/HA_on_off_light.
4+
5+
**This example is based on ESP-Zigbee-SDK example esp_zigbee_HA_sample/HA_on_off_light.**
56

67
# Supported Targets
78

Diff for: libraries/ESP32/examples/Zigbee/Zigbee_Light_Bulb/Zigbee_Light_Bulb.ino

+4-4
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,10 @@
1818
* The example demonstrates how to use ESP Zigbee stack to create a end device light bulb.
1919
* The light bulb is a Zigbee end device, which is controlled by a Zigbee coordinator.
2020
*
21-
* Please check the README.md for more detailed description.
21+
* Proper Zigbee mode must be selected in Tools->Zigbee mode
22+
* and also the correct partition scheme must be selected in Tools->Partition Scheme.
23+
*
24+
* Please check the README.md for instructions and more detailed description.
2225
*/
2326

2427
#ifndef ZIGBEE_MODE_ED
@@ -170,9 +173,6 @@ static esp_err_t zb_attribute_handler(const esp_zb_zcl_set_attr_value_message_t
170173

171174
/********************* Arduino functions **************************/
172175
void setup() {
173-
Serial.begin(115200);
174-
while(!Serial);
175-
176176
// Init Zigbee
177177
esp_zb_platform_config_t config = {
178178
.radio_config = ESP_ZB_DEFAULT_RADIO_CONFIG(),

Diff for: libraries/ESP32/examples/Zigbee/Zigbee_Light_Switch/.skip.esp32c6

Whitespace-only changes.

Diff for: libraries/ESP32/examples/Zigbee/Zigbee_Light_Switch/.skip.esp32h2

Whitespace-only changes.

Diff for: libraries/ESP32/examples/Zigbee/Zigbee_Light_Switch/README.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
# Arduino-ESP32 Zigbee Light Switch Example
22

33
This example shows how to configure Zigbee Coordinator and use it as an HA on/off light switch.
4-
This example is based on ESP-Zigbee-SDK example esp_zigbee_HA_sample/HA_on_off_switch.
4+
5+
**This example is based on ESP-Zigbee-SDK example esp_zigbee_HA_sample/HA_on_off_switch.**
56

67
# Supported Targets
78

Diff for: libraries/ESP32/examples/Zigbee/Zigbee_Light_Switch/Zigbee_Light_Switch.ino

+3-4
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,10 @@
1919
* The light bulb is a Zigbee end device, which is controlled by a Zigbee coordinator.
2020
* Button switch and Zigbee runs in separate tasks.
2121
*
22-
* Please check the README.md for more detailed description.
22+
* Proper Zigbee mode must be selected in Tools->Zigbee mode
23+
* and also the correct partition scheme must be selected in Tools->Partition Scheme.
2324
*
25+
* Please check the README.md for instructions and more detailed description.
2426
*/
2527

2628
#ifndef ZIGBEE_MODE_ZCZR
@@ -279,9 +281,6 @@ static void switch_button_detected(void *arg)
279281

280282
/********************* Arduino functions **************************/
281283
void setup() {
282-
Serial.begin(115200);
283-
while(!Serial);
284-
285284
// Init Zigbee
286285
esp_zb_platform_config_t config = {
287286
.radio_config = ESP_ZB_DEFAULT_RADIO_CONFIG(),

0 commit comments

Comments
 (0)