Skip to content

Commit 1e1dd8b

Browse files
setPins fix ESP32 "specified pins are not supported by this chip." (#7646)
[ESP32: SDMMCFS::begin hardcodes the usage of slot 1, only check if the pins match slot 1 pins.] setPins() was testing pins D1, D2 and D3 all against D1 ... fine in 1 pin mode when all are -1 not so much if you're trying to get 4 pin mode working. I now see this function doesn't really do anything on the ESP32...accept now correctly checks that you are trying to use the slot 1 pins. Co-authored-by: Jan Procházka <[email protected]>
1 parent 7b72da6 commit 1e1dd8b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Diff for: libraries/SD_MMC/src/SD_MMC.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,8 @@ bool SDMMCFS::setPins(int clk, int cmd, int d0, int d1, int d2, int d3)
7272
(d0 == (int)SDMMC_SLOT1_IOMUX_PIN_NUM_D0) &&
7373
(((d1 == -1) && (d2 == -1) && (d3 == -1)) ||
7474
((d1 == (int)SDMMC_SLOT1_IOMUX_PIN_NUM_D1) &&
75-
(d1 == (int)SDMMC_SLOT1_IOMUX_PIN_NUM_D2) &&
76-
(d1 == (int)SDMMC_SLOT1_IOMUX_PIN_NUM_D3)));
75+
(d2 == (int)SDMMC_SLOT1_IOMUX_PIN_NUM_D2) &&
76+
(d3 == (int)SDMMC_SLOT1_IOMUX_PIN_NUM_D3)));
7777
if (!pins_ok) {
7878
log_e("SDMMCFS: specified pins are not supported by this chip.");
7979
return false;

0 commit comments

Comments
 (0)